From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81307 invoked by alias); 4 Mar 2020 14:13:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81237 invoked by uid 89); 4 Mar 2020 14:13:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Mar 2020 14:13:11 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6DA60B2D9; Wed, 4 Mar 2020 14:13:09 +0000 (UTC) Subject: Re: [PATCH][gdb] Remove trailing "done" after "Reading symbols from" message To: Andrew Burgess Cc: gdb-patches@sourceware.org References: <20200304132133.GA26507@delia> <20200304140757.GZ3317@embecosm.com> From: Tom de Vries Message-ID: <99800816-3525-99a6-c287-b58215d93279@suse.de> Date: Wed, 04 Mar 2020 14:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200304140757.GZ3317@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-03/txt/msg00087.txt On 04-03-2020 15:07, Andrew Burgess wrote: > * Tom de Vries [2020-03-04 14:21:34 +0100]: > >> Hi, >> >> Using verbose, we get some detail on symbol loading: >> ... >> $ gdb a.out -iex "set verbose on" >> Reading symbols from a.out... >> Reading in symbols for /home/vries/hello.c...done. >> (gdb) >> ... >> >> And using debug symtab-create, much more detail: >> ... >> $ gdb a.out -iex "set verbose on" -iex "set debug symtab-create 1" >> Reading symbols from a.out... >> Reading minimal symbols of objfile /data/gdb_versions/devel/lto/a.out ... >> Installing 30 minimal symbols of objfile /data/gdb_versions/devel/lto/a.out. >> Done reading minimal symbols. >> Creating one or more psymtabs for objfile /data/gdb_versions/devel/lto/a.out ... >> Created psymtab 0x35a3de0 for module ../sysdeps/x86_64/start.S. >> Created psymtab 0x353e4e0 for module init.c. >> Created psymtab 0x353e560 for module ../sysdeps/x86_64/crti.S. >> Created psymtab 0x353e5e0 for module /home/vries/hello.c. >> Created psymtab 0x35bd530 for module elf-init.c. >> Created psymtab 0x35bd5b0 for module ../sysdeps/x86_64/crtn.S. >> Reading in symbols for /home/vries/hello.c...Created compunit symtab 0x354bd20 for hello.c. >> done. >> (gdb) > > I'm struggling to understand what problem you're trying to solve > here. In general, if we switch on any of the 'set debug ...' flags > the output from GDB gets confused. These flags aren't intended for > general use, and trying to "fix" GDB's output in the face of these > flags is going to be a huge task, for I'm not sure what benefit. > > Other than the output looking a little neater, is there an actual > problem solved here? This patch is intended to make the output look a little neater. OK for trunk? Thanks, - Tom