From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67897 invoked by alias); 17 Jul 2017 11:00:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61189 invoked by uid 89); 17 Jul 2017 11:00:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=guild, Guild X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 11:00:19 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B1184DD49; Mon, 17 Jul 2017 11:00:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5B1184DD49 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 5B1184DD49 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4CA67D924; Mon, 17 Jul 2017 11:00:06 +0000 (UTC) Subject: Re: [PATCH 09/40] Rename make_symbol_completion_list_fn -> symbol_completer To: Keith Seitz , gdb-patches@sourceware.org, Yao Qi References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-10-git-send-email-palves@redhat.com> <5967DC1F.309@redhat.com> From: Pedro Alves Message-ID: <993db576-e1bc-7aae-1bf6-899f83fcf6b1@redhat.com> Date: Mon, 17 Jul 2017 11:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5967DC1F.309@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00222.txt.bz2 On 07/13/2017 09:46 PM, Keith Seitz wrote: > On 06/02/2017 05:22 AM, Pedro Alves wrote: >> "make_symbol_completion_list_fn" is odly named when you look at a list >> of "standard" completers, like the Python/Guild completer lists >> adjusted by this patch. Rename / move it to completers.h/c, for >> consistency. > > Oh, man, I totally agree. make_symbol_completion_list_fn sounds more like a typedef name! > > And who could possibly complain about shortening symtab.[ch]. Those files are already a little bloated with non-symtab stuff. > > I see no issues with this patch. Thanks guys. I pushed this one in. -- Pedro Alves