From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nlriFTNA1GOzEiMAWB0awg (envelope-from ) for ; Fri, 27 Jan 2023 16:20:51 -0500 Received: by simark.ca (Postfix, from userid 112) id 5121E1E128; Fri, 27 Jan 2023 16:20:51 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=YvtBw0DK; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 063601E0D3 for ; Fri, 27 Jan 2023 16:20:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 244F53858C50 for ; Fri, 27 Jan 2023 21:20:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 244F53858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674854450; bh=sRJUIWFrys2SUbST1ALc1aYgXkHxmNKJlyXMQFyKaVU=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YvtBw0DKD7H6aoasZuuv6O29g/rlz1873ExaK3avOw+aNbhkMvmtzCcoHhlCme5iy 8x6v+VzbXGy6AS8WsBJSi4TZc6P6phFnmBIwzgZAf7pANgTAvBH8mSqPPD2Fcjtnzt CxvfDaMXSFmtpiDLT8ENcQgdEZY1vemRD6P3jFKM= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id B1D913858D20 for ; Fri, 27 Jan 2023 21:20:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B1D913858D20 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 24DAA1E0D3; Fri, 27 Jan 2023 16:20:31 -0500 (EST) Message-ID: <993c562b-ff57-771d-f13f-654a85701239@simark.ca> Date: Fri, 27 Jan 2023 16:20:30 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] Make addrmap const-correct in cooked index Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20230127162603.4127820-1-tromey@adacore.com> <8446b53b-bd73-637b-7613-45c896d7240f@simark.ca> <87cz6zptg4.fsf@tromey.com> In-Reply-To: <87cz6zptg4.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 1/27/23 16:18, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> -void * > Simon> +const void * > Simon> addrmap_fixed::find (CORE_ADDR addr) const > Simon> { > Simon> const struct addrmap_transition *bottom = &transitions[0]; > > Actually, this is going to rely on casting away const in some spots. > > For example cooked_index::lookup: > > dwarf2_per_cu_data *lookup (CORE_ADDR addr) const > { > return (dwarf2_per_cu_data *) m_addrmap->find (addr); > } > > Probably we can't constify dwarf2_per_cu_data all over. I suppose in this case we can consider that it's the DWARF code that is broken, and that it knows the risks of casting away the const. But at least the addrmap code will be correct. Simon