From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C23mJqUU7mSpqQ0AWB0awg (envelope-from ) for ; Tue, 29 Aug 2023 11:54:13 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=pY+9izEZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 932C01E0C2; Tue, 29 Aug 2023 11:54:13 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 51D561E092 for ; Tue, 29 Aug 2023 11:54:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9012438555A4 for ; Tue, 29 Aug 2023 15:54:10 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id 7E77D38582B0 for ; Tue, 29 Aug 2023 15:53:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E77D38582B0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4RZsRS42tZz4vHZ; Tue, 29 Aug 2023 15:53:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RZsRR6q3Hz3YVS; Tue, 29 Aug 2023 15:53:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693324436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/l/yZX6h18MU9eA+e1wR5mPMiteTQ3NZgfRelmPEFvA=; b=pY+9izEZx7lE1rNFKRc2Lam07quUoRo3YgAWO0HlMRitdgxzw9mivIcZQWXq2LWjvWnQbP 84jbO6kkblhMRKHDD90X7HYWxbjg0gbv7JNdWl5G+m/P7S5YfzvYSWK2vkE2pCngOWUYQU Qq1cbhju/amMy//XliIe6UtW2Sl7H/r8ZmK+vmrNLRC0JaGVbx6rsxxfPajtqAGig14kwN YP2ENJR41Ii9SY0wjeo2YMFcRTpN1cxJiBycZQzuaQLgQXRfpLAXV+RZuJatsp6gXCTCKZ /6ufgwztN/Jzsf6bVKKh4ozg+GvA8BwsVhE5zveibfXTCi+5w/m1D0ETWoUi/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693324436; a=rsa-sha256; cv=none; b=dK70At1KomFiNgSnAsF/hvnWPeYMYdMeCmBDi7033klV0ibeaW7eG2XBQbu/XXYm/D3dnP IIgC9ov2XfC8SHImFDNAURBBi5rOin/wYLrkZhLgEhKW9kalIb7mtoNVP5qUogVXJOvahN e6yZ8EghTVQc20zUwBnTalqIWJuw4AxVmq34v5kUecq/uzXFT0yn2G1V/UCIxkeypD5r50 ldYmwQdWw+XnU89BWLGz6qbUB6DVFd85AfxeXUY515S7iflBG4dUBH35E7qeqAnI1KnZQX JOkM8vZ1H01xnSjqNvmM5hTIST9mqUDO5YprTMlNgMtgTVR4v9RrWUYW1zwGQw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693324436; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/l/yZX6h18MU9eA+e1wR5mPMiteTQ3NZgfRelmPEFvA=; b=ml68Fh8FQRM45CeExNRkUgGiPvZjGmFcuGAyQrjYNzBJxVozhCzpoB0sreVFxosSXEHm09 dJAVQhBrmcnxys86s3XL9VkNovNH/7j469z5EyO2l3uD0fVAu4qaCOGp7XeEWMiAd0z7PE pC5u68X7c99vqd3F+uLooQOeeDczMMWKXem3gyX6mpnx1AKe54Pkk0eOq1mq/fU3h8f6Ii IS4rMwTVHxQ5WxsEDZWqMwTSpnyydiL8gJtNjkMc3ukMqwvcl900b6qJxCJnHOG+lObtbn 7nhFCjU5sB5HYDIcZs6tekAqblG8gXQVkeZnpgW+L+NQWRkLxMBRQAedHXlvzQ== Received: from [IPV6:2601:648:8683:a9e0:9cd8:9cdb:14b9:93d0] (unknown [IPv6:2601:648:8683:a9e0:9cd8:9cdb:14b9:93d0]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4RZsRR3Wftz14yL; Tue, 29 Aug 2023 15:53:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <98f5aa43-b7ae-5521-f86a-b742426fb27a@FreeBSD.org> Date: Tue, 29 Aug 2023 08:53:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] [gdb/build] Fix C inclusion of nat/x86-cpuid.h Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20230829153857.12895-1-tdevries@suse.de> From: John Baldwin In-Reply-To: <20230829153857.12895-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 8/29/23 8:38 AM, Tom de Vries via Gdb-patches wrote: > When running test-case gdb.arch/i386-avx512.exp, I run into: > ... > gdb compile failed, In file included from gdb.arch/i386-avx512.c:20:0: > src/gdb/nat/x86-cpuid.h: In function 'x86_cpuid_count': > src/gdb/nat/x86-cpuid.h:63:16: error: \ > 'nullptr' undeclared (first use in this function) > if (__eax == nullptr) > ^~~~~~~ > src/gdb/nat/x86-cpuid.h:63:16: note: each \ > undeclared identifier is reported only once for each function it appears in > > === gdb Summary === > > # of untested testcases 1 > ... > > This is due to commit e85aad4ae76 ("nat/x86-cpuid.h: Add x86_cpuid_count > wrapper around __get_cpuid_count"), which introduced the nullptr check. > > The header file gdb/nat/x86-cpuid.h is a file that is included in the build > and compiled as a C++ file, but also in the testsuite and compiled as a C > file. > > Fix this by replacing nullptr with (void *)0. > > Tested on x86_64-linux. This seems obvious to me, please push. -- John Baldwin