From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81969 invoked by alias); 27 Dec 2018 00:46:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81811 invoked by uid 89); 27 Dec 2018 00:45:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=played, sometime, Hx-languages-length:854 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Dec 2018 00:45:45 +0000 Received: by simark.ca (Postfix, from userid 112) id 951831E7B3; Wed, 26 Dec 2018 19:45:43 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 858CA1E4B1; Wed, 26 Dec 2018 19:45:40 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 27 Dec 2018 00:46:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [PATCH 00/12] Remove some ALL_* iteration macros In-Reply-To: <87a7krq2cb.fsf@tromey.com> References: <20181125165439.13773-1-tom@tromey.com> <20181223070033.GB8096@adacore.com> <87zhsuprvq.fsf@tromey.com> <6e551a8d-6c3a-de70-38f3-82ec286a47aa@simark.ca> <87muorq5wo.fsf@tromey.com> <87imzfq5qq.fsf@tromey.com> <5a866c46-31bb-6b83-c737-5a2c170c0f01@simark.ca> <87efa3q4t9.fsf@tromey.com> <87a7krq2cb.fsf@tromey.com> Message-ID: <98db74fefda4685225fefdb4a04e74c7@simark.ca> X-Sender: simark@simark.ca User-Agent: Roundcube Webmail/1.3.6 X-SW-Source: 2018-12/txt/msg00346.txt.bz2 On 2018-12-26 18:45, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > >>>>>> "Simon" == Simon Marchi writes: > Simon> Usually, the problem I had was the other way around, that > having the struct tag > Simon> causes a compilation problem: > > Tom> Aha, that's what I misremembered. > Tom> Ok, I can fix that. > > I did it. A few spots needed an additional tweak to avoid a clash > between a variable ("objfile" or "symtab") and the type. > I've force-pushed it to that same branch, in case you feel like giving > it a try. I'll re-send the series sometime. When I played with it, the compiler did not complain when I used: for (objfile *objfile : ...) That was with gcc 8.2.0. Do you know if it's really problematic with other compilers/versions? Simon