Re: -Wtautological-bitwise-compare error in arm-tdep.c

Simon Marchi
2020-05-25T13:49:32Z

On 2020-05-25 9:08 a.m., Luis Machado wrote:
> This fixes an instruction mask typo. We should be matching only
> ldrd (immediate) and not any other of its variants. As is, it never matches
> anything.

And moreover, within the `ldrd (immediate)` instruction, it only matches the
`Offset variant` variant, right?

>
> With the patch, the instruction mask also allows matching of ldrd (literal),
> but the check for SP discards this particular instruction pattern, as it has
> a hardcoded PC register.

I don't feel the most qualified to approve this patch. Alan, could you please
take a look?

Simon