From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QFjvG27AGWG3dAAAWB0awg (envelope-from ) for ; Sun, 15 Aug 2021 21:33:34 -0400 Received: by simark.ca (Postfix, from userid 112) id 61A0A1EDFB; Sun, 15 Aug 2021 21:33:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 840A31E79C for ; Sun, 15 Aug 2021 21:33:33 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D75DA386186A for ; Mon, 16 Aug 2021 01:33:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D75DA386186A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1629077612; bh=zThMYvd8KECZEn3F80eUsSJ1gsNLH5lanWymg6MxcAg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=wrkJy4SxJG7JzqahwFkimULcsEDbcIqYOnczS3ms/6imNk7VnTX5nca18Jp7z7i4Y 8g3UOzFjZjt3mdMFX7cLZnWVIMP8CQymdlFT32bkAjGCLlhLFWoLyjszvR5Zz0ruW2 YEzNZayS5quf45HfoprvTLJpcUbl+BOajRxdQJl8= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 79C8E3858434 for ; Mon, 16 Aug 2021 01:33:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79C8E3858434 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17G1WnHa014548 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Aug 2021 21:32:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17G1WnHa014548 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 68C381E79C; Sun, 15 Aug 2021 21:32:49 -0400 (EDT) Subject: Re: [PATCH] Notify observer of breakpoint auto-disabling To: Patrick Monnerat , gdb-patches@sourceware.org References: <20210815003308.10218-1-patrick@monnerat.net> Message-ID: <98687805-6ab5-6164-9e76-e0ce9756f947@polymtl.ca> Date: Sun, 15 Aug 2021 21:32:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210815003308.10218-1-patrick@monnerat.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 16 Aug 2021 01:32:49 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-08-14 8:33 p.m., Patrick Monnerat via Gdb-patches wrote: > As breakpoint_modified observer is currently notified upon breakpoint stop > before handling auto-disabling when enable count is reached, the observer is > never notified of the disabling. > > The problem affects: > - The MI interpreter enabled= value when reporting =breakpoint-modified > - A Python event handler for breakpoint_modified using the "enabled" > member of its parameter > - insight: breakpoint GUI window is not properly updated upon auto-disable > > This patch moves the observer notification after the auto-disabling > code and implements corresponding tests for the MI and Python cases. Thanks for writing test cases. It looks good, just some nits to fix. > +proc test_auto_disable { } { > + global mi_gdb_prompt > + global lib_sl1 lib_sl2 > + global binfile > + > + mi_clean_restart $binfile > + > + mi_load_shlibs $lib_sl1 $lib_sl2 > + > + mi_runto_main > + > + # Set the breakpoint. > + mi_gdb_test "-break-insert -f pendfunc1" \ > + {(&.*)*.*~"Breakpoint 2 at.*\\n".*=breakpoint-created,bkpt=\{number="2",type="breakpoint".*\}.*\n\^done} > + > + # Enable for one shot only. > + mi_gdb_test "-break-enable count 1 2" \ > + {=breakpoint-modified,bkpt=\{number="2",type="breakpoint",disp="dis",enabled="y".*\}.*\n\^done} > + > + mi_send_resuming_command "exec-continue" "continuing execution to breakpoint" > + > + set test "breakpoint auto-disabling after enable count reached" > + gdb_expect { > + -re ".*=breakpoint-modified,bkpt=\{number=\"2\".*enabled=\"n\"" { > + pass $test There are some issues with the indentation in the new code, groups of 8 spaces should be replaced with a tab. For example, the above should be one tab + 4 spaces (see the existing code for an example). > + } > + -re ".*${mi_gdb_prompt}$" { > + fail $test > + } > + timeout { > + fail "$test (timeout)" > + } > + } > +} > + > +with_test_prefix "test_auto_disable" { > + test_auto_disable > +} > diff --git a/gdb/testsuite/gdb.python/py-breakpoint.exp b/gdb/testsuite/gdb.python/py-breakpoint.exp > index e2ffe8cbe46..e9102e7e3ea 100644 > --- a/gdb/testsuite/gdb.python/py-breakpoint.exp > +++ b/gdb/testsuite/gdb.python/py-breakpoint.exp > @@ -799,6 +799,26 @@ proc_with_prefix test_catchpoints {} { > gdb_test "continue" "Stopped at catchpoint event: ${num}" > } > > +proc_with_prefix test_bkpt_auto_disable { } { Please add a small comment above the proc indicating the intent of the test. > + global srcfile testfile hex decimal > + > + # Start with a fresh gdb. > + clean_restart ${testfile} > + > + if ![runto_main] then { > + fail "cannot run to main." > + return 0 > + } > + delete_breakpoints > + > + set mult_line [gdb_get_line_number "Break at multiply."] > + gdb_breakpoint ${mult_line} > + gdb_test "enable count 1 2" "" "One shot enable." You can use the "gdb_test_no_output" proc. Also, test messages start with a lower case letter and don't end with a period. Simon