From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68092 invoked by alias); 13 Jun 2016 14:25:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68031 invoked by uid 89); 13 Jun 2016 14:25:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=stale, H*M:957b, Hx-languages-length:772 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 14:24:56 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 13CE3811A2; Mon, 13 Jun 2016 14:24:55 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DEOrvM024187; Mon, 13 Jun 2016 10:24:54 -0400 Subject: Re: [PATCH 01/12] Switch to current thread in finish_step_over To: Yao Qi , gdb-patches@sourceware.org References: <1464859846-15619-1-git-send-email-yao.qi@linaro.org> <1464859846-15619-2-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <98589a43-40ec-957b-5d35-1c191feb63c3@redhat.com> Date: Mon, 13 Jun 2016 14:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464859846-15619-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00228.txt.bz2 On 06/02/2016 10:30 AM, Yao Qi wrote: > V2: move current_thread switch into finsh_step_over Thanks. > This patch switched current_thread to the thread we are doing step-over > in complete_ongoing_step_over. > ^ This sentence is now stale. > gdb/gdbserver: > > 2016-05-31 Yao Qi > > * linux-low.c (maybe_hw_step): New function. > (linux_resume_one_lwp_throw): Call maybe_hw_step. > (finish_step_over): Switch current_thread to lwp temporarily, > and assert has_reinsert_breakpoints returns true. > (proceed_one_lwp): Call maybe_hw_step. > * mem-break.c (has_reinsert_breakpoints): New function. > * mem-break.h (has_reinsert_breakpoints): Declare. Otherwise OK. Thanks, Pedro Alves