From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-147152-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 71029 invoked by alias); 7 May 2018 14:35:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 71012 invoked by uid 89); 7 May 2018 14:35:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:731, Javaid, javaid, omair
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 May 2018 14:35:27 +0000
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id AEE369BA4B;	Mon,  7 May 2018 14:35:25 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id EE9F62024CA1;	Mon,  7 May 2018 14:35:24 +0000 (UTC)
Subject: Re: [RFA 1/2] Fix decoding of ARM VFP instructions
To: Tom Tromey <tom@tromey.com>, Omair Javaid <omair.javaid@linaro.org>
References: <20180421214721.7232-1-tom@tromey.com> <20180421214721.7232-2-tom@tromey.com> <CANW4E-0qnudezdKcWH+c64AUbK-LUjWanbgCuuHFUTGBSeT2sg@mail.gmail.com> <87a7tf2vwf.fsf@tromey.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <98105a00-42db-7296-534e-d7789da05590@redhat.com>
Date: Mon, 07 May 2018 14:35:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <87a7tf2vwf.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-05/txt/msg00170.txt.bz2

On 05/04/2018 06:06 PM, Tom Tromey wrote:
>>>>>> "Omair" == Omair Javaid <omair.javaid@linaro.org> writes:
> 
>>> On 22 April 2018 at 02:47, Tom Tromey <tom@tromey.com> wrote:
>>> -Wduplicated-cond pointed out that arm_record_vfp_data_proc_insn
>>> checks "opc1 == 0x0b" twice.  I filed this a while ago as
>>> PR tdep/20362.
>>>
>>> Based on the ARM instruction manual at
>>> https://www.scss.tcd.ie/~waldroj/3d1/arm_arm.pdf, I think the
>>> instruction decoding in this function has two bugs.
> [...]
> 
> Omair> Seems LGTM. Let me get back to you after running testsuite for regressions.
> 
> Did this work out?

FAOD, this is OK if there are no regressions.

Thanks,
Pedro Alves