Re: [PATCH 1/3] gdb: add convenience variables around linker namespace debugging

[Guinevere Larsen <guinevere@redhat.com>]

On 4/7/25 12:39 PM, Eli Zaretskii wrote:
>> From: Guinevere Larsen <guinevere@redhat.com>
>> Cc: Guinevere Larsen <guinevere@redhat.com>
>> Date: Mon,  7 Apr 2025 11:54:41 -0300
>>
>> This commit adds 2 simple built-in convenience variables to help users
>> debug an inferior with multiple linker namespaces. The first is
>> $_active_namespaces, which just counts how many namespaces have SOs
>> loaded onto them. The second is $_current_namespace, and it tracks which
>> namespace does the current location in the inferior belongs to.
>>
>> This commit also introduces a test ensuring that we track namespaces
>> correctly, and that a user can use the $_current_namespace variable to
>> set a conditional breakpoint, while linespec changes aren't finalized to
>> make it more convenient.
>> ---
>>   gdb/NEWS                                     |  5 ++
>>   gdb/doc/gdb.texinfo                          | 12 +++++
>>   gdb/solib-svr4.c                             |  6 +++
>>   gdb/solib.c                                  | 42 +++++++++++++++
>>   gdb/testsuite/gdb.base/default.exp           |  2 +
>>   gdb/testsuite/gdb.base/dlmopen-ns-ids-main.c |  6 +++
>>   gdb/testsuite/gdb.base/dlmopen-ns-ids.exp    | 55 ++++++++++++++++++++
>>   7 files changed, 128 insertions(+)
> Thanks.
>
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -40,6 +40,11 @@
>>     namespace into which the library was loaded, if more than one namespace
>>     is active.
>>   
>> +* New built-in convenience variables $_active_namespaces and
>> +  $_current_namespace.  These show the number of active linkage namespaces,
>> +  and which one the current location belongs to. In systems that don't
>                                                    ^^
> Two spaces there, please.
>
> Also, I find the following minor rewording easier to grasp:
>
>    These show the number of active linkage namespaces, and the
>    namespace to which the current location belongs.
>
>> +@item $_active_namespaces
>> +@vindex $_active_namespaces@r{, convenience variable}
> Please always put the indexing commands _before_ the @item which they
> index, so that the corresponding command in the Info reader moves the
> cursor to the @item and not after it.
>
>> +@item $_current_namespace
>> +@vindex $_current_namespace@r{, convenience variable}
> Likewise.
>
>> +Which namespace contains the current location in the inferior.
> "The namespace which contains the current location in the inferior."
>
>>                                                                   This returns
>> +GDB's internal identifier for namespaces, which is @samp{[[]]} with an
>> +integer in the middle.
> It is better to show than to describe:
>
>    This returns @value{GDBN}'s internal identifier for namespaces,
>    which is @samp{[[@var{n}]]}, where @var{n} is a zero-based namespace
>    number.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>
Thanks for the review, I applied all the fixes and your tag

-- 
Cheers,
Guinevere Larsen
She/Her/Hers