From: Simon Marchi <simark@simark.ca>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
gdb-patches@sourceware.org
Cc: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
Subject: Re: [PATCH] gdb: Skip useless minsym scan in variable-only symbol searches
Date: Tue, 29 Sep 2026 10:25:16 -0400 [thread overview]
Message-ID: <97a93306-d296-466f-91ea-514bdc7d9352@simark.ca> (raw)
In-Reply-To: <75d35221-7a84-4aa8-8e67-570e5e90c544@linaro.org>
On 2026-09-29 09:32, Adhemerval Zanella Netto wrote:
>>
>> LGTM with that fixed.
>>
>> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
> May I assume that I could push the patch with the above fixes?
Yes, this is what we mean with "LGTM with that fixed" (maybe I should
have said "with those fixed" since there was more than one comment).
Please go ahead and push.
Simon
prev parent reply other threads:[~2026-09-29 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 15:51 Adhemerval Zanella
2026-09-23 21:47 ` Thiago Jung Bauermann
2026-09-26 4:34 ` Simon Marchi
2026-09-29 13:32 ` Adhemerval Zanella Netto
2026-09-29 14:25 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a93306-d296-466f-91ea-514bdc7d9352@simark.ca \
--to=simark@simark.ca \
--cc=adhemerval.zanella@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox