From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90781 invoked by alias); 6 Mar 2019 10:06:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90689 invoked by uid 89); 6 Mar 2019 10:06:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-22.6 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GARBLED_BODY,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy==d0=be=d0=b2, 06032019, 06.03.2019, H*RU:sk:broadba?= X-HELO: mail-lj1-f194.google.com Received: from mail-lj1-f194.google.com (HELO mail-lj1-f194.google.com) (209.85.208.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 10:06:12 +0000 Received: by mail-lj1-f194.google.com with SMTP id z7so10344639lji.0 for ; Wed, 06 Mar 2019 02:06:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:references:from:autocrypt:subject:message-id:date:user-agent :mime-version:in-reply-to; bh=swfdkFvQMYEIddqsliMOQFcrjpXUCYtwkv0H1qu8Oio=; b=sOC2+gnDiYHidT77UibaZZu0g0/so7PCice6DbFAhgJMIFciyr85viitWNmuQsBHqW 8OYC/hkQJpO9i+byBZVXGzk/uiVXG8qCAFP3Cb964bUF1AJXX7WRkGP9mxCNI/15oAw/ 6rvOszt7HO/CipZD5flGjiXVxpldtWbQ9gj98PQZ9K1y5igjpHnxs4iYpprpp3G/wlUg KWzwXzpmKcj2rCUGZP/LKZN3EpT/5oEe42gfgNOq/wE+aaZEnZy8yHWDR/dBcBN5b8Fx 6L3nWZHcASTbAYTXW2KUXcLbYbsgelK5DytTTEVJHLxCnlEAd8THHlscQmDFPFeGziyH J+oA== Return-Path: Received: from [192.168.4.39] (broadband-95-84-200-6.ip.moscow.rt.ru. [95.84.200.6]) by smtp.gmail.com with ESMTPSA id z4sm242771ljz.43.2019.03.06.02.06.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 02:06:07 -0800 (PST) To: gdb-patches@sourceware.org References: <5a785bba-7432-f6e0-1089-5d2bdd3450a3@gmail.com> <871s3lq8fy.fsf@tromey.com> From: LRN Subject: Re: [PATCH] Apply substitute-path to relative filenames as well Message-ID: <97a68efd-1c71-000d-88eb-7bbec121f36e@gmail.com> Date: Wed, 06 Mar 2019 10:06:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <871s3lq8fy.fsf@tromey.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TE15za9vCK59Zxcoo7nQ9SIJE0GmDRldo" X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00082.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --TE15za9vCK59Zxcoo7nQ9SIJE0GmDRldo Content-Type: multipart/mixed; boundary="CkoirNQI2iQjIvBSL6jgbmUQqKwWgnGqA"; protected-headers="v1" From: LRN To: gdb-patches@sourceware.org Message-ID: <97a68efd-1c71-000d-88eb-7bbec121f36e@gmail.com> Subject: Re: [PATCH] Apply substitute-path to relative filenames as well --CkoirNQI2iQjIvBSL6jgbmUQqKwWgnGqA Content-Type: multipart/mixed; boundary="------------B49161DDACAD031FB917E098" Content-Language: en-US This is a multi-part message in MIME format. --------------B49161DDACAD031FB917E098 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1375 On 06.03.2019 1:10, Tom Tromey wrote: > LRN writes: >> 2019-02-28 =D0=A0=D1=83=D1=81=D0=BB=D0=B0=D0=BD =D0=98=D0=B6=D0=B1=D1=83= =D0=BB=D0=B0=D1=82=D0=BE=D0=B2 >>=20 >> * source.c (find_and_open_source): Apply substitute-path to all >> filenames, both absolute and relative >=20 > Is it possible to get a test case for the patch? No. I couldn't find a gdb testcase for the substitute-path feature (there's= one that checks issuing the `set substitute-path` command itself, but it doesn't seem to be testing its *runtime effect*, i.e. how it is applied when gdb ne= eds to read a source file), so i can't provide a test case for this change by modifying an existing one. That means i'd have to write one from scratch, a= nd i wouldn't know how to even begin to do that. Also, running gdb testsuite requires dejagnu, which i don't have (and by "i don't have" i mean "i've never built it from the source", as this is how i = get 90% of all my dev software). It should technically be possible for me to bu= ild it, but that'll take time that i would rather spend on other things. >> gdb::unique_xmalloc_ptr rewritten_filename; > [...] >> + rewritten_filename =3D rewrite_source_path (filename); >=20 > I think these two lines can now be joined; no need to have a separate > assignment. >=20 New version of the patch is attached. --------------B49161DDACAD031FB917E098 Content-Type: text/plain; charset=UTF-8; name="0001-Apply-substitute-path-to-relative-filenames-as-well.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Apply-substitute-path-to-relative-filenames-as-well.pat"; filename*1="ch" Content-length: 3945 RnJvbSA3NGVjODFjYjUxOWMzMzFkOGIxMGQ0MTllZWZhMmE1OTlmYWMyZjRl IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQw PUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQwPUIwPUQwPUJEPTIwPUQwPTk4PUQw PUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9RDA9QjA9RDE9 ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IFRo dSwgMjggRmViIDIwMTkgMTA6MjU6NDEgKzAwMDAKU3ViamVjdDogW1BBVENI XSBBcHBseSBzdWJzdGl0dXRlLXBhdGggdG8gcmVsYXRpdmUgZmlsZW5hbWVz IGFzIHdlbGwKCldoZW4gc291cmNlIGZpbGUgcGF0aCBpcyByZWxhdGl2ZSB0 byB0aGUgYnVpbGQgZGlyZWN0b3J5ICh3aGljaAppcyBjb25zaWRlcmVkIGEg Z29vZCBwcmFjdGljZSBhbmQgaXMgZW5mb3JjZWQgaW4gY2VydGFpbiBidWls ZHN5c3RlbXMsCnN1Y2ggYXMgbWVzb24pLCBnZGIgb25seSBhcHBsaWVzIHN1 YnN0aXR1dGUtcGF0aCB0byB0aGUgYnVpbGQgZGlyZWN0b3J5CnBhdGguIFRo ZW4gZ2RiIGFwcGVuZHMgdGhlIHNvdXJjZSBmaWxlIHBhdGggdG8gdGhlIHJl d3JpdHRlbiBidWlsZApkaXJlY3RvcnkgcGF0aCwgYW5kIHRyaWVzIHRvIGFj Y2VzcyB0aGF0LgoKVGhpcyBmYWlscyBpZiBlaXRoZXIgdHdvIG9mIHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucyBhcmUgdHJ1ZToKYSkgVGhlIHVzZXIgZGlk bid0IHNwZWNpZnkgc3Vic3RpdHV0ZS1wYXRoIGZvciB0aGUgYnVpbGQgZGly ZWN0b3J5LgogICBUaGlzIGlzIGhpZ2hseSBsaWtlbHksIHNpbmNlIHBhdGgg c3Vic3RpdHV0aW9uIGZvciBidWlsZCBkaXJlY3RvcmllcwogICBpcyBub3Qg ZG9jdW1lbnRlZCBhbnl3aGVyZSwgYW5kIHNpbmNlIGdkYiBkb2VzIG5vdCB0 ZWxsWzBdIHRoZSB1c2VyCiAgIHRoZSBwYXRoIHRvIHRoZSBidWlsZCBkaXJl Y3RvcnksIGp1c3QgdGhlIHNvdXJjZSBmaWxlIHBhdGguCmIpIFRoZSBzb3Vy Y2UgZmlsZSBwYXRoIGNoYW5nZWQuCiAgIFRoaXMgY2FuIGFsc28gZWFzaWx5 IGhhcHBlbiwgc2luY2UgYSBzb3VyY2UgcGF0aCB0aGF0IGlzIHJlbGF0aXZl CiAgIHRvIHRoZSBidWlsZCBkaXJlY3RvcnkgY2FuIGluY2x1ZGUgYW55IG51 bWJlciBvZiBkaXJlY3RvcnkgbmFtZXMKICAgdGhhdCBhcmUgbm90IHBhcnQg b2YgdGhlIHByb2dyYW0gc291cmNlIHRyZWUgKHN0YXJ0aW5nIHdpdGggdGhl CiAgIG5hbWUgb2YgdGhlIHJvb3QgZGlyZWN0b3J5IG9mIHRoZSBzb3VyY2Ug dHJlZSkuIEdkYiB3aWxsIG5vdCBhcHBseQogICBzdWJzdGl0dXRlLXBhdGgg dG8gdGhhdCByZWxhdGl2ZSBwYXRoLCB0aHVzIHRoZXJlIGlzIG5vIHdheSBm b3IKICAgdGhlIHVzZXIgdG8gdGVsbCBnZGIgYWJvdXQgdGhlc2UgY2hhbmdl cy4KClRoaXMgY29tbWl0IGNoYW5nZXMgdGhlIGNvZGUgdG8gYXBwbHkgc3Vi c3RpdHV0ZS1wYXRoIHRvIGFsbCBmaWxlbmFtZXMsCmJvdGggcmVsYXRpdmUg YW5kIGFic29sdXRlLiBUaGlzIHdheSBpdCBpcyBwb3NzaWJsZSB0byBkbyB0 aGluZ3MgbGlrZToKCnNldCBzdWJzdGl0dXRlLXBhdGggLi4vZm9vYmFyLTEu MCAvc3JjL215L2Zvb2Jhci0xLjAKCndoaWNoIGlzIGNvbXBsZXRlbHkgaW4g bGluZSB3aXRoIHRoZSB1c2VyIGV4cGVjdGF0aW9ucy4KClRoaXMgbWlnaHQg YnJlYWsgdW51c3VhbCBjYXNlcyB3aGVyZSBidWlsZCBkaXJlY3RvcnkgcGF0 aCBpcyBhbHNvCnJlbGF0aXZlIChpcyB0aGF0IGV2ZW4gcG9zc2libGU/KSBh bmQgaGFwcGVucyB0byBtYXRjaCB0aGUgcGF0aAp0byB0aGUgc291cmNlIGRp cmVjdG9yeSAoaS5lLiBoYXBwZW5zIHRvIG1hdGNoIGEgc3Vic3RpdHV0aW9u IHJ1bGUpLgoKWzBdOiBUaGVyZSdzIGEgIm1haW50ZW5hbmNlIGluZm8gc3lt dGFicyIgY29tbWFuZCB0aGF0IGRvZXMgc2hvdyB0aGUgbmFtZXMKICAgICBv ZiB0aGUgYnVpbGQgZGlyZWN0b3JpZXMsIGJ1dCBub3JtYWwgdXNlcnMgYXJl IG5vdCByZXF1aXJlZCB0bwogICAgIGtub3cgb3IgdXNlIHRoYXQuCi0tLQog Z2RiL3NvdXJjZS5jIHwgMTIgKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMyBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2dkYi9zb3VyY2UuYyBiL2dkYi9zb3VyY2UuYwppbmRleCBmOTkyMTVm Li4zZmM3NzE3IDEwMDY0NAotLS0gYS9nZGIvc291cmNlLmMKKysrIGIvZ2Ri L3NvdXJjZS5jCkBAIC0xMDI3LDE2ICsxMDI3LDEwIEBAIGZpbmRfYW5kX29w ZW5fc291cmNlIChjb25zdCBjaGFyICpmaWxlbmFtZSwKIAl9CiAgICAgfQog Ci0gIGdkYjo6dW5pcXVlX3htYWxsb2NfcHRyPGNoYXI+IHJld3JpdHRlbl9m aWxlbmFtZTsKLSAgaWYgKElTX0FCU09MVVRFX1BBVEggKGZpbGVuYW1lKSkK LSAgICB7Ci0gICAgICAvKiBJZiBmaWxlbmFtZSBpcyBhYnNvbHV0ZSBwYXRo LCB0cnkgdGhlIHNvdXJjZSBwYXRoCi0JIHN1YnN0aXR1dGlvbiBvbiBpdC4g ICovCi0gICAgICByZXdyaXR0ZW5fZmlsZW5hbWUgPSByZXdyaXRlX3NvdXJj ZV9wYXRoIChmaWxlbmFtZSk7CisgIGdkYjo6dW5pcXVlX3htYWxsb2NfcHRy PGNoYXI+IHJld3JpdHRlbl9maWxlbmFtZSA9IHJld3JpdGVfc291cmNlX3Bh dGggKGZpbGVuYW1lKTsKIAotICAgICAgaWYgKHJld3JpdHRlbl9maWxlbmFt ZSAhPSBOVUxMKQotCWZpbGVuYW1lID0gcmV3cml0dGVuX2ZpbGVuYW1lLmdl dCAoKTsKLSAgICB9CisgIGlmIChyZXdyaXR0ZW5fZmlsZW5hbWUgIT0gTlVM TCkKKyAgICBmaWxlbmFtZSA9IHJld3JpdHRlbl9maWxlbmFtZS5nZXQgKCk7 CiAKICAgcmVzdWx0ID0gb3BlbnAgKHBhdGgsIE9QRl9TRUFSQ0hfSU5fUEFU SCB8IE9QRl9SRVRVUk5fUkVBTFBBVEgsIGZpbGVuYW1lLAogCQkgIE9QRU5f TU9ERSwgZnVsbG5hbWUpOwotLSAKMi40LjAKCg== --------------B49161DDACAD031FB917E098-- --CkoirNQI2iQjIvBSL6jgbmUQqKwWgnGqA-- --TE15za9vCK59Zxcoo7nQ9SIJE0GmDRldo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 833 -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE4MWzR43wYaAzEA49ja3pJ2dZunQFAlx/m4gACgkQja3pJ2dZ unR+wQ//d7CTEq3zDfn7jNQbh47UzERy5stZ8qCXWUz38SFpX1jeqz3b+lFfE14c 9+RWyiDmWjnMoJY35/zzVUl/0I2mmBUMLa0dtanuf9ZZoxURpTdlbr6YR7n1DVDt aSc6cjqP5YrtZA0zCRwEW+cq02kFYew0KNTzTyFLndEK/jvvZUJZP6gPTdIaVYNr W2RUgIMIAA544xAVv/PrlMZUFAy4lOv7qOSmyGdNZ8jnyRYRE93IY6mZarIyIoPK Q9qRkZ1ftwrm4DKDvjObIkkuieQYen9Ftx5N6poQu3sqv1xPZWHiM44CnbfJSLf9 TmlKzwqXPelHfojd6KaJtKjmPjXe5Scw22+QCQQj+qUPaBZ+tt8awddFURyEaYgF Z9OnDbSGFHnZu3aJJSDgKGUV4knqLC1298lpJ8L19KLWeWcsGYnEEHx2U+8soMHq 0gjznEz2k0Px+HqKJGHICrR632v/YxUUT3E5MaaYdWdRPYO36gy94r5ZKanH8sB3 jRtlg+RLBsMaLDPPgjraI/ZCQG/Kcu3NMH9TG1KnN2gDA9sZOs9M2pf101LVPzlN umlfk91+OU6dOE/69fP6NfKql4WIgfLuMd6yWyyt4XJwcbSh/bPzF8rIZmqspRJx WWI9dly790YP+TJlaKW+tg+bE0agJo5rdbaYiHh3cqYbs2v/Tjo= =Rf95 -----END PGP SIGNATURE----- --TE15za9vCK59Zxcoo7nQ9SIJE0GmDRldo--