From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95212 invoked by alias); 7 Jul 2018 15:41:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95199 invoked by uid 89); 7 Jul 2018 15:41:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=instantiated X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Jul 2018 15:41:36 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D53601E08D; Sat, 7 Jul 2018 11:41:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1530978094; bh=MyGbomrWEzQBY8d2OQqN62Ru4T8Fe2M+Q0f5O9ylBEg=; h=Subject:To:References:From:Date:In-Reply-To:From; b=ujfRZRZ7S7cEpffkopFBk/7Df71UWnlIU3ioin+vKygG8MfTfEUfZl8Ctj1IdX42w 0CcAtXm7tIwZNK+FQ/2Z+SumZtEOtiYBkSuNmJ0PkxUdQtzJLOMo6ggGFuoBjztz3E yjnzG+ZVSrNCMILEXip8rjDBkn07lQETTfhlSWmw= Subject: Re: [RFA 05/42] Move pending_macros to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-6-tom@tromey.com> From: Simon Marchi Message-ID: <97a59543-69e0-e330-61f2-f8bd64eaf4ce@simark.ca> Date: Sat, 07 Jul 2018 15:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-6-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00172.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > This moves the pending_macros global into buildsym_compunit. LGTM. As in the other patch, I would like it if the new fields were private though. The only access of m_pending_macros outside the class is to check if the macro table is instantiated. So it could be replaced with this method: bool has_macro_table () const { return m_pending_macros != nullptr; } Simon