From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17871 invoked by alias); 6 Sep 2017 18:44:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15791 invoked by uid 89); 6 Sep 2017 18:43:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Sep 2017 18:43:54 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v86IhljI019776 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 6 Sep 2017 14:43:52 -0400 Received: by simark.ca (Postfix, from userid 112) id AEC8E1EAA0; Wed, 6 Sep 2017 14:43:47 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 2A6A81EA18; Wed, 6 Sep 2017 14:43:47 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 06 Sep 2017 18:44:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Add selftests run filtering In-Reply-To: <6ad827ae97e146194f5f644fb35b320e@polymtl.ca> References: <1504612227-7159-1-git-send-email-simon.marchi@ericsson.com> <0cc25dd0-4311-28e8-f0ca-443719354bed@redhat.com> <148b3fcdbb9bfbbb51589f585d1f3f5b@polymtl.ca> <6ad827ae97e146194f5f644fb35b320e@polymtl.ca> Message-ID: <97798d29959f571b9718251b17a30408@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 6 Sep 2017 18:43:47 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00166.txt.bz2 On 2017-09-06 20:41, Simon Marchi wrote: > On 2017-09-06 20:37, Simon Marchi wrote: >> On 2017-09-06 17:25, Pedro Alves wrote: >>> Sounds useful. >>> >>> Patch looks fine to me. Nits and comments below. >>> >>> I wonder whether we'll want to be able to do select tests >>> with e.g., a regexp instead of exact matching. If we do, then >>> the std::vector->std::map change would seem pointless. >> >> Not sure I understand. I am not using exact matching now either, so >> using a map is probably already pointless. I am not sure what lead me >> there, maybe I started with the intent of using exact matching. I'll >> change it to a vector of a new struct type. > > Ah, now I remember. It was so we could easily check that there isn't > already a test with this name, when registering a new test. It's > won't break anything if we happened to have two tests with the same > name, so I can just remove this check. Oh, and also so it would automatically iterate in alphabetical order, I thought it was prettier :).