From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6939 invoked by alias); 23 Oct 2018 16:42:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6920 invoked by uid 89); 23 Oct 2018 16:42:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=laster, UD:ca X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Oct 2018 16:42:03 +0000 Received: by simark.ca (Postfix, from userid 112) id 7A9B01EA6F; Tue, 23 Oct 2018 12:42:01 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1540312921; bh=IFjgywo+29dhq2qRpicrvnYEgRw59Qq+wz0oaXIBIVU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v/HFTcCkM+hevxh0lkVvi2RaLR9io6Tu0KNsmI7rtyOIqg+r6yzNmUzyrqZPEsHH2 pz4G8SHgEQrrDCVr78fQYTkEL631J45+dXKm5tvU/TpGrEvo0akfurTUwLTBSx5JGi Fn6gcw4HAxSYWMfZzBFawjvAMt9j+yR69z/2GxCw= Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 44FAB1E514; Tue, 23 Oct 2018 12:42:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1540312920; bh=IFjgywo+29dhq2qRpicrvnYEgRw59Qq+wz0oaXIBIVU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O7AIpU5w90jPCJ/qAhwoCzrs8rVQ0thzKqCVVmDkzAd2jL4EW68RqiVcRafGIwcWO 9Nf4WEMSzuvdb1nV0pau45f5zIcmkXPMsMoATWiIzI6BytGfCyjSruZKjqhvGl6h71 WkYAyXmAZA+aFCI55NB8ojIoLoOEKPrfFiyHlvQI= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 23 Oct 2018 16:42:00 -0000 From: Simon Marchi To: Hafiz Abid Qadeer Cc: gdb-patches@sourceware.org, jiangshuai_li@c-sky.com Subject: Re: [1/2] C-SKY Port In-Reply-To: References: <1b689bab-bb28-7ba9-9602-d66f0568ff28@simark.ca> <1799f181-2531-dc53-4934-6f436a2b858c@simark.ca> Message-ID: <9777cb488fab070bc4e1a05ce4b9fbed@simark.ca> X-Sender: simark@simark.ca User-Agent: Roundcube Webmail/1.3.6 X-SW-Source: 2018-10/txt/msg00514.txt.bz2 On 2018-10-23 08:48, Hafiz Abid Qadeer wrote: >> A quick investigation shows it's because some raw registers are not in >> the >> save reggroup. So csky should probably be added to that big if in the >> test: >> >> if (bfd_arch == bfd_arch_frv || bfd_arch == bfd_arch_h8300 >> || bfd_arch == bfd_arch_m32c || bfd_arch == bfd_arch_sh >> || bfd_arch == bfd_arch_alpha || bfd_arch == bfd_arch_v850 >> || bfd_arch == bfd_arch_msp430 || bfd_arch == bfd_arch_mep >> || bfd_arch == bfd_arch_mips || bfd_arch == bfd_arch_v850_rh850 >> || bfd_arch == bfd_arch_tic6x || bfd_arch == bfd_arch_mn10300 >> || bfd_arch == bfd_arch_rl78 || bfd_arch == bfd_arch_score >> || bfd_arch == bfd_arch_riscv) >> { >> /* Raw registers. If raw registers are not in save_reggroup, >> their status are unknown. */ >> if (gdbarch_register_reggroup_p (gdbarch, regnum, >> save_reggroup)) >> SELF_CHECK (status == REG_VALID); >> else >> SELF_CHECK (status == REG_UNKNOWN); >> } >> else >> SELF_CHECK (status == REG_VALID); >> > > When I was reviewing the test results for csky, I saw this fail in > unittest.exp and fixed it by adding csky to the big if list as you > mentioned above. Somehow I missed that patch when upstreaming the port. > So if you are happy with that change then I will push it. Yes please, consider it pre-approved. We can take a look at removing the big list laster. Thanks, Simon