From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54768 invoked by alias); 8 Jul 2018 16:10:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54756 invoked by uid 89); 8 Jul 2018 16:10:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 08 Jul 2018 16:10:24 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3459E1E059; Sun, 8 Jul 2018 12:10:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531066223; bh=hRYYjNyBwoJ6DR0nwopfKnN6hW4ZEeKAEF4k6Kl7luk=; h=Subject:To:References:From:Date:In-Reply-To:From; b=h38Hx1bz7dLRTRf7qrYXLoZWCj3h/ALSi73V3X0tLGGcTHOshWq/p1nsvjexpYIza YMQbqcB8rNpK2OBlmG/2Xim5rB35RMTPAcOMbZXSjXJld7N6y0Ks5ihPeas1iAaNaJ pJy5u5WrSGU0SpcVNfSP3rVBn/H/n9mM2IK8Le3U= Subject: Re: [RFA 07/42] Move last_source_start_addr to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-8-tom@tromey.com> From: Simon Marchi Message-ID: <97704168-258d-85a1-9c4a-2e87803f7d01@simark.ca> Date: Sun, 08 Jul 2018 16:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-8-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00181.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > This moves the global last_source_start_addr into buildsym_compunit, > adding some accessors as well. LGTM, though same comment as earlier, where I would prefer the m_ member to be private. Simon