From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75777 invoked by alias); 13 Jul 2017 22:40:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75758 invoked by uid 89); 13 Jul 2017 22:40:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:832 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Jul 2017 22:40:44 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 28418C00576A; Thu, 13 Jul 2017 22:40:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 28418C00576A Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 28418C00576A Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 597626060C; Thu, 13 Jul 2017 22:40:41 +0000 (UTC) Subject: Re: [PATCHv2 2/2] gdb: Make some test names unique To: Andrew Burgess , gdb-patches@sourceware.org References: <20170713201511.GH27353@embecosm.com> Cc: Yao Qi From: Pedro Alves Message-ID: <975f251d-36db-6e69-6435-6be598628077@redhat.com> Date: Thu, 13 Jul 2017 22:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170713201511.GH27353@embecosm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-07/txt/msg00173.txt.bz2 On 07/13/2017 09:15 PM, Andrew Burgess wrote: > Thanks for the review and feedback. I've taken on-board what you both > said, and I have a new patch which I think should be fine, in this I: > > - Add '(...text...)' at the end, but only _without_ a space before > the '('. > > - I no longer use line numbers to make test names unique, instead I > use more descriptive text. > > - I've not changed the names of any tests that were already unique, > even if those names included a line number. > > OK to apply? OK. Though I'd think avoiding ()s entirely in the cases that the ()s are not part of the expression would be less surprising, like e.g.: -"evaluate filled vla(contents modified)" +"evaluate filled vla, contents modified" OK with that change too. Thanks, Pedro Alves