From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yIsoJDY1YWcqLx4AWB0awg (envelope-from ) for ; Tue, 17 Dec 2024 03:24:22 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=c7Q23B0D; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 903741E097; Tue, 17 Dec 2024 03:24:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 428751E05C for ; Tue, 17 Dec 2024 03:24:22 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDE923858C60 for ; Tue, 17 Dec 2024 08:24:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDE923858C60 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=c7Q23B0D Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by sourceware.org (Postfix) with ESMTPS id A37493858410 for ; Tue, 17 Dec 2024 08:19:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A37493858410 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A37493858410 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734423568; cv=none; b=pV7drPggY+s4gLHiBGbytozpnogvA0YHkJYIDkaZMyYifEDcKWQZFoJ4MyPu1iJVB2h250iaSwVkguHFuqtcI7h4/ZSIeWghEN5zi3/VEXyW2yTMsTZUUCun4T2i9rquFZtwOv0Ch8Nhf9k6IaTmzn2JLQiWrMogjSqKp5L/6Os= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734423568; c=relaxed/simple; bh=U7dc3RMq0MVhaXjAvJxmOPnx/0W6Xfvt5G5jG/RIABY=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jMXzS3/wo1jPhQ/dmidoQ+ZJ/ZIucq0y7gXyu2VI5GntteytTkgaVurtTwomch+fb0LBq4TqfEsf7vX7PC+M6mRw7gviviJgekF+ZlplmpvTIDTvu1Vl+QHlmMA1V+1xScElaH85DmDe9hRQS9ImkXkUAhbFMjKmzwjrDW2bo30= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A37493858410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734423568; x=1765959568; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U7dc3RMq0MVhaXjAvJxmOPnx/0W6Xfvt5G5jG/RIABY=; b=c7Q23B0Dti+kXs/u3mTe8XXKUP4VPaa3UGF3Oj+ClDCw4ipVtdKEdZrX 6V+ONNLYA/S8QY0hiI23c3ngFhjnpdchM9Vs1l4WKTrDoP4gQgz8btGZX WB0Q3RnSItUL66SvaIIZ/esPNlc+3Vaat8RKKk6K3sLlPY81RGN0q8Wem n+u7Qk5eXCD/dRrUNRUlQLGHcoa9EEOgbwddkwBiPchiEklzlO0MfbuKd fZ4zWnXrZMY8N9xYJ61vNkJ2jU54vKv+HpN5As8B4ODNufkX2+HbmyLJ4 cl+BdFNaoxV0HbSb4fFnUSAL5SijtXzGvW28flXf9w8+HmRr+Q4q/tKBi w==; X-CSE-ConnectionGUID: 5x5eYiCvRJGYte4VXr10VQ== X-CSE-MsgGUID: m4bvAY/tQlyKVQbt8sZNMg== X-IronPort-AV: E=McAfee;i="6700,10204,11288"; a="34160432" X-IronPort-AV: E=Sophos;i="6.12,241,1728975600"; d="scan'208";a="34160432" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 00:19:27 -0800 X-CSE-ConnectionGUID: 8Olrc/Z6Rz63vEtGiaC2zg== X-CSE-MsgGUID: GbiuH5nsS1yaPL/F8Oxzrg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,241,1728975600"; d="scan'208";a="128278772" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2024 00:19:26 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Cc: simon.marchi@efficios.com Subject: [PUSHED 8/8] gdbserver: return tracked register status in regcache_raw_read_unsigned Date: Tue, 17 Dec 2024 09:18:30 +0100 Message-Id: <975318ed49fd5725cf10f6c52fe14605e5cbea6a.1734422730.git.tankut.baris.aktemur@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org In regcache_raw_read_unsigned, we unconditionally return REG_VALID as the register status. This does not seem right, since the register may in fact be in another state, such as REG_UNAVAILABLE. Return the tracked status. Approved-By: Simon Marchi --- gdbserver/regcache.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc index dad0907291b..5b064ae04d1 100644 --- a/gdbserver/regcache.cc +++ b/gdbserver/regcache.cc @@ -474,7 +474,7 @@ regcache_raw_read_unsigned (reg_buffer_common *reg_buf, int regnum, *val = 0; collect_register (regcache, regnum, val); - return REG_VALID; + return regcache->get_register_status (regnum); } #ifndef IN_PROCESS_AGENT -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928