From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36803 invoked by alias); 20 Feb 2019 19:05:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36781 invoked by uid 89); 20 Feb 2019 19:05:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=HX-Received:sk:a18mr24, noted X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Feb 2019 19:05:30 +0000 Received: by mail-wr1-f66.google.com with SMTP id n2so15133912wrw.8 for ; Wed, 20 Feb 2019 11:05:29 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:75e6:857f:3506:a1f4? ([2001:8a0:f913:f700:75e6:857f:3506:a1f4]) by smtp.gmail.com with ESMTPSA id e7sm27475202wrw.35.2019.02.20.11.05.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 11:05:27 -0800 (PST) Subject: Re: [PATCH] Use Python 2.[67] / 3.X / PEP 3118 buffer protocol To: Kevin Buettner , gdb-patches@sourceware.org References: <20190219145110.03bccce6@f29-4.lan> From: Pedro Alves Message-ID: <974b7419-3cbf-cf1e-256e-1724c96eb5d9@redhat.com> Date: Wed, 20 Feb 2019 19:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190219145110.03bccce6@f29-4.lan> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00337.txt.bz2 On 02/19/2019 09:51 PM, Kevin Buettner wrote: > As noted earlier, Python 2.6, Python 2.7, and Python 3.X all have > support for the PEP 3118 buffer protocol. Python releases prior > to 2.6 use an older buffer protocol. Since Python 2.6 has been > retired for a good while now, it seems reasonable to me to remove > code using the older buffer protocol from GDB. > > I have also simplified some of the code via use of the Py_buffer > unique_ptr specialization which I introduced in the two argument > gdb.Value constructor patch series. Therefore, there is a dependency > on patch #1 from that series. Not objecting, but I think you should send an email to gdb@ with a clear subject indicating that you're proposing to drop support for Python < 2.6. Thanks, Pedro Alves