From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19377 invoked by alias); 3 Oct 2003 18:14:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19367 invoked from network); 3 Oct 2003 18:14:56 -0000 Received: from unknown (HELO frigg.inter.net.il) (192.114.186.16) by sources.redhat.com with SMTP; 3 Oct 2003 18:14:56 -0000 Received: from zaretski ([80.230.149.192]) by frigg.inter.net.il (Mirapoint Messaging Server MOS 3.3.7-GR) with ESMTP id CVP39369; Fri, 3 Oct 2003 20:14:46 +0200 (IST) Date: Fri, 03 Oct 2003 18:14:00 -0000 From: "Eli Zaretskii" To: Andrew Cagney Message-Id: <9743-Fri03Oct2003201110+0200-eliz@elta.co.il> CC: gdb-patches@sources.redhat.com In-reply-to: <3F7C630B.1040506@redhat.com> (message from Andrew Cagney on Thu, 02 Oct 2003 13:40:27 -0400) Subject: Re: [patch/rfc, rfa:doco] gdbarch return value Reply-to: Eli Zaretskii References: <3F7C630B.1040506@redhat.com> X-SW-Source: 2003-10/txt/msg00052.txt.bz2 > Date: Thu, 02 Oct 2003 13:40:27 -0400 > From: Andrew Cagney > > This implements the "return_value" method I proposed earlier this week. > It replaces USE_STRUCT_CONVENTION, EXTRACT_RETURN_VALUE, and > STORE_RETURN_VALUE. The implementation is fallout from me fixing the > ppc64 return code and finding that a single "reurn_value" method lead to > more robust code. The doco part is okay with me, but I'd suggest to move this paragraph: +Given a function with a return-value of type @var{rettype}, return which +return-value convention that function would use. right after these two lines: +@item enum return_value_convention gdbarch_return_value (struct gdbarch *@var{gdbarch}, struct type *@var{valtype}, struct regcache *@var{regcache}, const void *@var{inval}, void *@var{outval}) +@findex gdbarch_return_value since it describes what the method does, while the rest explains more about the matter.