From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Qs7VNWzr3WJx/RkAWB0awg (envelope-from ) for ; Sun, 24 Jul 2022 21:01:32 -0400 Received: by simark.ca (Postfix, from userid 112) id CF0DA1E5EA; Sun, 24 Jul 2022 21:01:32 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=XO76DI3Y; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DDAB41E21F for ; Sun, 24 Jul 2022 21:01:31 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72FC2385357D for ; Mon, 25 Jul 2022 01:01:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72FC2385357D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1658710891; bh=fAgFyT+rH+lLucDdjBsn6VeSHmC8YWFY5GCIWdberIE=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XO76DI3Ye9vuz1AjRm2sDI0m6drIdau+tQ05Hj4vFvDIHKqPov7N4197SSMVTF1nS MyZZBKKpLIA+1wFY0vwiBld6tFGD0gvzIaXe3OqaFB6jPLSKUwZ7H5S8Nmow7OfHZy wLl4RMM9n8/1E0SfHXkFQiMQv+TCjdT5e4iS5LUE= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6EA263858298 for ; Mon, 25 Jul 2022 01:01:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EA263858298 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id ADE1C1E21F; Sun, 24 Jul 2022 21:01:11 -0400 (EDT) Message-ID: <96a2fc09-113a-887c-c458-72568967b78a@simark.ca> Date: Sun, 24 Jul 2022 21:01:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] gdb/netbsd: add missing header file Content-Language: en-US To: Enze Li , gdb-patches@sourceware.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: enze.li@gmx.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022-07-23 22:55, Enze Li via Gdb-patches wrote: > I ran into this error when building GDB on NetBSD: > > CXX netbsd-nat.o > netbsd-nat.c: In member function 'virtual bool nbsd_nat_target::info_proc(const char*, info_proc_what)': > netbsd-nat.c:314:3: error: 'gdb_argv' was not declared in this scope > gdb_argv built_argv (args); > ^~~~~~~~ > netbsd-nat.c:314:3: note: suggested alternative: 'gdbarch' > gdb_argv built_argv (args); > ^~~~~~~~ > gdbarch > netbsd-nat.c:315:7: error: 'built_argv' was not declared in this scope > if (built_argv.count () == 0) > ^~~~~~~~~~ > netbsd-nat.c:315:7: note: suggested alternative: 'buildargv' > if (built_argv.count () == 0) > ^~~~~~~~~~ > buildargv > gmake[2]: *** [Makefile:1893: netbsd-nat.o] Error 1 > > Fix this by adding the missing header file, as it is obvious. > > Tested by rebuilding on NetBSD/amd64. > --- > gdb/netbsd-nat.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/netbsd-nat.c b/gdb/netbsd-nat.c > index c45df391afc..8a4a43270d6 100644 > --- a/gdb/netbsd-nat.c > +++ b/gdb/netbsd-nat.c > @@ -25,6 +25,7 @@ > #include "netbsd-tdep.h" > #include "inferior.h" > #include "gdbarch.h" > +#include "gdbsupport/buildargv.h" > > #include > #include LGTM. Simon