RE: [PATCH v6 0/9] Python bindings for btrace recordings

Wiederhake, Tim
2017-02-14T10:20:05Z

Hi all,

> > Is this good to go?
> LGTM

... And in return I made a mess. What should have been a "git push --dry-run" to prepare for pushing this, ended up as an actual push. The commits now miss the actual ChangeLog entries and contain some "Change-Id" lines. Before I start fiddeling and probably make things worse, could you tell me how to properly resolve this?

Thanks,
Tim

> -----Original Message-----
> From: Doug Evans [mailto:xdje42@gmail.com]
> Sent: Monday, February 13, 2017 6:18 PM
> To: Wiederhake, Tim <tim.wiederhake@intel.com>
> Cc: gdb-patches@sourceware.org; Metzger, Markus T
> <markus.t.metzger@intel.com>; palves@redhat.com
> Subject: Re: [PATCH v6 0/9] Python bindings for btrace recordings
>
> Tim Wiederhake <tim.wiederhake@intel.com> writes:
> > Hello everyone!
> >
> > This patch series adds Python bindings for btrace recordings.
> >
> > V1 of this series can be found here:
> > https://sourceware.org/ml/gdb-patches/2016-10/msg00733.html
> >
> > V2 of this series can be found here:
> > https://sourceware.org/ml/gdb-patches/2016-11/msg00084.html
> >
> > V3 of this series can be found here:
> > https://sourceware.org/ml/gdb-patches/2016-11/msg00605.html
> >
> > V4 of this series can be found here:
> > https://sourceware.org/ml/gdb-patches/2017-01/msg00044.html
> >
> > V5 of this series can be found here:
> > https://sourceware.org/ml/gdb-patches/2017-01/msg00616.html
> >
> > Changes from V5:
> > - Skip gdb.python/py-record-full.exp if recording is not supported.
> > - s/symbol/SAL/ in comment in py-record-btrace.c.
> > - Replaced mem_fileopen by string_file in py-record-btrace.c.
> > - Simplified btpy_list_count and added comment in py-record-btrace.c.
> > - Removed unused variable in recpy_bt_goto (leftover from previous
> refactoring)
> > in py-record-btrace.c.
> > - Moved opening curly braces to new line in py-record-btrace.c.
> >
> > The documentation parts are already approved by Eli.
> >
> > Is this good to go?
>
> LGTM
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928