From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57206 invoked by alias); 14 Feb 2017 10:20:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57172 invoked by uid 89); 14 Feb 2017 10:20:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_50,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Simplified, UD:py-record-btrace.c, sk:py-reco, sk:pyreco X-HELO: mga09.intel.com Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Feb 2017 10:19:54 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2017 02:19:52 -0800 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga002.fm.intel.com with ESMTP; 14 Feb 2017 02:19:51 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.38]) by IRSMSX153.ger.corp.intel.com ([169.254.9.160]) with mapi id 14.03.0248.002; Tue, 14 Feb 2017 10:18:34 +0000 From: "Wiederhake, Tim" To: Doug Evans CC: "gdb-patches@sourceware.org" , "Metzger, Markus T" , "palves@redhat.com" Subject: RE: [PATCH v6 0/9] Python bindings for btrace recordings Date: Tue, 14 Feb 2017 10:20:00 -0000 Message-ID: <9676A094AF46E14E8265E7A3F4CCE9AF94021F@irsmsx105.ger.corp.intel.com> References: <1486989450-11313-1-git-send-email-tim.wiederhake@intel.com> In-Reply-To: Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00380.txt.bz2 Hi all, > > Is this good to go? > LGTM ... And in return I made a mess. What should have been a "git push --dry-ru= n" to prepare for pushing this, ended up as an actual push. The commits now= miss the actual ChangeLog entries and contain some "Change-Id" lines. Befo= re I start fiddeling and probably make things worse, could you tell me how = to properly resolve this? Thanks, Tim > -----Original Message----- > From: Doug Evans [mailto:xdje42@gmail.com] > Sent: Monday, February 13, 2017 6:18 PM > To: Wiederhake, Tim > Cc: gdb-patches@sourceware.org; Metzger, Markus T > ; palves@redhat.com > Subject: Re: [PATCH v6 0/9] Python bindings for btrace recordings >=20 > Tim Wiederhake writes: > > Hello everyone! > > > > This patch series adds Python bindings for btrace recordings. > > > > V1 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2016-10/msg00733.html > > > > V2 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2016-11/msg00084.html > > > > V3 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2016-11/msg00605.html > > > > V4 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2017-01/msg00044.html > > > > V5 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2017-01/msg00616.html > > > > Changes from V5: > > - Skip gdb.python/py-record-full.exp if recording is not supported. > > - s/symbol/SAL/ in comment in py-record-btrace.c. > > - Replaced mem_fileopen by string_file in py-record-btrace.c. > > - Simplified btpy_list_count and added comment in py-record-btrace.c. > > - Removed unused variable in recpy_bt_goto (leftover from previous > refactoring) > > in py-record-btrace.c. > > - Moved opening curly braces to new line in py-record-btrace.c. > > > > The documentation parts are already approved by Eli. > > > > Is this good to go? >=20 > LGTM Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928