From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40951 invoked by alias); 4 Sep 2017 06:57:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40939 invoked by uid 89); 4 Sep 2017 06:57:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=sunday, Sunday, sk:gdb-pat, sk:gdbpat X-HELO: mga11.intel.com Received: from mga11.intel.com (HELO mga11.intel.com) (192.55.52.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Sep 2017 06:57:44 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Sep 2017 23:57:42 -0700 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga001.fm.intel.com with ESMTP; 03 Sep 2017 23:57:41 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.75]) by IRSMSX153.ger.corp.intel.com ([169.254.9.34]) with mapi id 14.03.0319.002; Mon, 4 Sep 2017 07:57:40 +0100 From: "Wiederhake, Tim" To: Simon Marchi , "gdb-patches@sourceware.org" CC: "Metzger, Markus T" Subject: RE: [PATCH] btrace: Store btrace_insn in an std::vector Date: Mon, 04 Sep 2017 06:57:00 -0000 Message-ID: <9676A094AF46E14E8265E7A3F4CCE9AF63631C0D@irsmsx105.ger.corp.intel.com> References: <1504429530-27720-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1504429530-27720-1-git-send-email-simon.marchi@ericsson.com> dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00026.txt.bz2 Hi Simon, > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Simon Marchi > Sent: Sunday, September 3, 2017 11:06 AM > To: gdb-patches@sourceware.org > Cc: Metzger, Markus T ; Wiederhake, Tim > ; Simon Marchi > Subject: [PATCH] btrace: Store btrace_insn in an std::vector >=20 > Because it contains a non-POD type field (flags), the type btrace_insn > should be new'ed/delete'd. Replace the VEC (btrace_insn_s) in > btrace_function with an std::vector. >=20 > gdb/ChangeLog: >=20 > * btrace.h (btrace_insn_s, DEF_VEC_O (btrace_insn_s)): Remove. > (btrace_function) : Change type to use std::vector. > * btrace.c (ftrace_debug, ftrace_call_num_insn, > ftrace_find_call, ftrace_new_gap, ftrace_update_function, > ftrace_update_insns, ftrace_compute_global_level_offset, > btrace_stitch_bts, btrace_clear, btrace_insn_get, > btrace_insn_end, btrace_insn_next, btrace_insn_prev): Adjust to > change to std::vector. > (ftrace_update_insns): Adjust to change to std::vector, change > type of INSN parameter. > (btrace_compute_ftrace_bts): Adjust call to ftrace_update_insns. > * record-btrace.c (btrace_call_history_insn_range, > btrace_compute_src_line_range, > record_btrace_frame_prev_register): Adjust to change to > std::vector. > * python/py-record-btrace.c (recpy_bt_func_instructions): Adjust > to change to std::vector. Looks good to me -- but I don't have approval power. Regards, Tim Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928