From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71480 invoked by alias); 11 May 2017 07:20:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71375 invoked by uid 89); 11 May 2017 07:20:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:3201 X-HELO: mga14.intel.com Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 May 2017 07:20:37 +0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 May 2017 00:20:38 -0700 X-ExtLoop1: 1 Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga006.fm.intel.com with ESMTP; 11 May 2017 00:20:38 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.163]) by irsmsx110.ger.corp.intel.com ([169.254.15.151]) with mapi id 14.03.0319.002; Thu, 11 May 2017 08:20:37 +0100 From: "Wiederhake, Tim" To: Simon Marchi CC: "gdb-patches@sourceware.org" , "Metzger, Markus T" Subject: RE: [PATCH v4 00/12] btrace: Turn linked list of function call segments into vector Date: Thu, 11 May 2017 07:20:00 -0000 Message-ID: <9676A094AF46E14E8265E7A3F4CCE9AF3C14D2D4@irsmsx105.ger.corp.intel.com> References: <1494416867-19612-1-git-send-email-tim.wiederhake@intel.com> In-Reply-To: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00283.txt.bz2 Hi Simon! > -----Original Message----- > From: Simon Marchi [mailto:simon.marchi@polymtl.ca] > Sent: Wednesday, May 10, 2017 4:47 PM > To: Wiederhake, Tim > Cc: gdb-patches@sourceware.org; Metzger, Markus T > > Subject: Re: [PATCH v4 00/12] btrace: Turn linked list of function call > segments into vector >=20 > On 2017-05-10 07:47, Tim Wiederhake wrote: > > Hi all, > > > > this series removes the extra list of btrace function call segments in > > struct > > btrace_thread_info. To achieve this, the doubly linked list of > > function call > > segments in struct btrace_thread_info is replaced by a std::vector. > > > > V1 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2017-02/msg00482.html > > > > V2 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2017-05/msg00168.html > > > > V3 of this series can be found here: > > https://sourceware.org/ml/gdb-patches/2017-05/msg00202.html > > > > Patches #1, #2 and #7 were LGTM'd by Simon. > > > > Changes since V3: > > * Patch #4: Replaced int with bool. Added comment that > > btrace_function::number > > is 1-based. > > * Patch #5: Simplified btrace_insn_cmp. > > * Patch #6: Split line that had an assignment as a side effect. Added > > missing > > comment. > > * Patch #9: Fixed patch title. > > * Patch #10: Fixed patch title. Removed double assignment in > > ftrace_bridge_gaps. > > * Patch #11: Moved comment to patch #6. Replaced "for (const auto& foo: > > ..." > > with "for (const unsigned int foo: ...". > > * Patch #12: Added missing ChangeLog. Put "static" before "const". > > Changed > > comment of ftrace_find_call_by_number. > > > > Regards, > > Tim > > > > Tim Wiederhake (12): > > btrace: Use std::vector in struct btrace_thread_information. > > btrace: Transfer ownership of pointers. > > btrace: Add btinfo to instruction interator. > > btrace: Use function segment index in call iterator. > > btrace: Use function segment index in insn iterator. > > btrace: Remove constant arguments. > > btrace: Remove struct btrace_thread_info::{begin,end}. > > btrace: Replace struct btrace_function::up. > > btrace: Remove struct btrace_function::flow. > > btrace: Replace struct btrace_function::segment. > > btrace: Remove bfun_s vector. > > btrace: Store function segments as objects. > > > > gdb/btrace.c | 850 > > +++++++++++++++++++++--------------------- > > gdb/btrace.h | 64 ++-- > > gdb/python/py-record-btrace.c | 12 +- > > gdb/record-btrace.c | 30 +- > > 4 files changed, 465 insertions(+), 491 deletions(-) >=20 > AFAIC, this series is good to go, pending your response on the > btrace_function initialization issue in patch #12. Thanks! I'll send an updated version of #12 in a minute. > Thanks, >=20 > Simon Regards, Tim Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928