From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87748 invoked by alias); 10 May 2017 11:46:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87672 invoked by uid 89); 10 May 2017 11:46:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mga01.intel.com Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 May 2017 11:46:33 +0000 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 04:46:34 -0700 X-ExtLoop1: 1 Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga002.fm.intel.com with ESMTP; 10 May 2017 04:46:33 -0700 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.163]) by IRSMSX103.ger.corp.intel.com ([169.254.3.241]) with mapi id 14.03.0319.002; Wed, 10 May 2017 12:46:32 +0100 From: "Wiederhake, Tim" To: Simon Marchi CC: "gdb-patches@sourceware.org" , "Metzger, Markus T" Subject: RE: [PATCH v3 09/12] btrace: Remove struct btrace_thread_info::flow. Date: Wed, 10 May 2017 11:46:00 -0000 Message-ID: <9676A094AF46E14E8265E7A3F4CCE9AF3C14CFD8@irsmsx105.ger.corp.intel.com> References: <1494312929-22749-1-git-send-email-tim.wiederhake@intel.com> <1494312929-22749-10-git-send-email-tim.wiederhake@intel.com> <1b056a5b6923e4357b0795d513b1d8cc@polymtl.ca> In-Reply-To: <1b056a5b6923e4357b0795d513b1d8cc@polymtl.ca> dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00248.txt.bz2 Hi Simon, thanks for reviewing! > -----Original Message----- > From: Simon Marchi [mailto:simon.marchi@polymtl.ca] > Sent: Wednesday, May 10, 2017 5:45 AM > To: Wiederhake, Tim > Cc: gdb-patches@sourceware.org; Metzger, Markus T > > Subject: Re: [PATCH v3 09/12] btrace: Remove struct > btrace_thread_info::flow. >=20 > The title should mention btrace_function::flow instead of > btrace_thread_info::flow. I just realized the previous patch has the > same issue. I have no idea how this escaped me for so long. Fixed. > On 2017-05-09 02:55, Tim Wiederhake wrote: > > This used to hold a pair of pointers to the previous and next function > > segment > > in execution flow order. It is no longer necessary as the previous and > > next > > function segments now are simply the previous and next elements in the > > vector > > of function segments. > > > > 2017-05-09 Tim Wiederhake > > > > gdb/ChangeLog: > > > > * btrace.c (ftrace_new_function, ftrace_fixup_level, > > ftrace_connect_bfun, ftrace_bridge_gap, btrace_bridge_gaps, > > btrace_insn_next, btrace_insn_prev): Remove references to > > btrace_thread_info::flow. >=20 > btrace_function::flow. >=20 > > * btrace.h (struct btrace_function): Remove FLOW. > > >=20 > The patch LGTM, but I have one question. Did you consider adding a > backlink in btrace_function to its btrace_thread_info owner? It would > possible to implement gap->next () and gap->prev (), which could be used > in many places, and would probably be more readable than >=20 > ftrace_find_call_by_number (btinfo, gap->number - 1) > ftrace_find_call_by_number (btinfo, gap->number + 1) >=20 > And it could possibly bring more simplifications, I didn't look in > details. I believe, a C++-ificiation patch series could get rid of call_iterator and= insn_iterator altogether. Sorry if I sound like a broken record :). >=20 > Thanks, >=20 > Simon Regards, Tim Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928