From: "Wiederhake, Tim" <tim.wiederhake@intel.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Metzger, Markus T" <markus.t.metzger@intel.com>
Subject: RE: [PATCH v2 00/11] btrace: Turn linked list of function call segments into vector
Date: Mon, 08 May 2017 10:23:00 -0000 [thread overview]
Message-ID: <9676A094AF46E14E8265E7A3F4CCE9AF3C14C9E7@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <86h90v3elw.fsf@gmail.com>
Hi Yao!
The one place I remembered from the top of my head (new_thread in thread.c) was C++ified in the meantime. I believe there was some place in remote.c as well, but I can't find any evidence at the moment.
I tried adding a non-trivial constructor to struct btrace_thread_info to see if any of the non-pod-poisoning-patches kicked in -- which did not happen.
So all in all, thanks for noticing me, I'll rewrite this series to use std::vector.
TIm
> -----Original Message-----
> From: Yao Qi [mailto:qiyaoltc@gmail.com]
> Sent: Monday, May 8, 2017 11:03 AM
> To: Wiederhake, Tim <tim.wiederhake@intel.com>
> Cc: gdb-patches@sourceware.org; Metzger, Markus T
> <markus.t.metzger@intel.com>
> Subject: Re: [PATCH v2 00/11] btrace: Turn linked list of function call
> segments into vector
>
> Tim Wiederhake <tim.wiederhake@intel.com> writes:
>
> > In some
> > instances, struct btrace_thread_info is initialized by memset'ing it to
> 0x00,
> > so we can't use std::vector (yet).
>
> What are these instances? I can't find them.
>
> --
> Yao (齐尧)
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2017-05-08 10:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 8:13 Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 07/11] btrace: Replace struct btrace_thread_info::up Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 06/11] btrace: Remove struct btrace_thread_info::{begin,end} Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 09/11] btrace: Replace struct btrace_thread_info::segment Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 01/11] btrace: Transfer ownership of pointers Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 05/11] btrace: Remove constant arguments Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 04/11] btrace: Use function segment index in insn iterator Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 10/11] btrace: Remove bfun_s vector Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 03/11] btrace: Use function segment index in call iterator Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 02/11] btrace: Add btinfo to instruction interator Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 11/11] btrace: Store function segments as objects Tim Wiederhake
2017-05-08 8:13 ` [PATCH v2 08/11] btrace: Remove struct btrace_thread_info::flow Tim Wiederhake
2017-05-08 9:03 ` [PATCH v2 00/11] btrace: Turn linked list of function call segments into vector Yao Qi via gdb-patches
2017-05-08 10:23 ` Wiederhake, Tim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9676A094AF46E14E8265E7A3F4CCE9AF3C14C9E7@irsmsx105.ger.corp.intel.com \
--to=tim.wiederhake@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox