Re: [PATCH v2 02/10] Register a placeholder for NetBSD shared functions in gdb/nat

Simon Marchi
2020-09-07T18:45:00Z

On 2020-09-03 8:28 p.m., Kamil Rytarowski wrote:
> gdb/ChangeLog:
>
> * netbsd-nat.h: New file.
> * netbsd-nat.c: Likewise.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/nat/netbsd-nat.c | 24 ++++++++++++++++++++++++
> gdb/nat/netbsd-nat.h | 27 +++++++++++++++++++++++++++
> 3 files changed, 56 insertions(+)
> create mode 100644 gdb/nat/netbsd-nat.c
> create mode 100644 gdb/nat/netbsd-nat.h
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index faa3a612547..430f9b58a78 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2020-09-04 Kamil Rytarowski <n54@gmx.com>
> +
> + * netbsd-nat.h: New file.
> + * netbsd-nat.c: Likewise.
> +
> 2020-09-03 Alok Kumar Sharma <AlokKumar.Sharma@amd.com>
>
> * gdb/i386-tdep.c (i386_floatformat_for_type): Added conditions
> diff --git a/gdb/nat/netbsd-nat.c b/gdb/nat/netbsd-nat.c
> new file mode 100644
> index 00000000000..2b5a4183e30
> --- /dev/null
> +++ b/gdb/nat/netbsd-nat.c
> @@ -0,0 +1,24 @@
> +/* Internal interfaces for the NetBSD code.
> +
> + Copyright (C) 2006-2020 Free Software Foundation, Inc.
> +
> + This file is part of GDB.
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 3 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program. If not, see <http://www.gnu.org/licenses/>. */
> +
> +#include "nat/netbsd-nat.h"
> +
> +namespace netbsd_nat
> +{
> +}
> diff --git a/gdb/nat/netbsd-nat.h b/gdb/nat/netbsd-nat.h
> new file mode 100644
> index 00000000000..5fa08746610
> --- /dev/null
> +++ b/gdb/nat/netbsd-nat.h
> @@ -0,0 +1,27 @@
> +/* Internal interfaces for the NetBSD code.
> +
> + Copyright (C) 2006-2020 Free Software Foundation, Inc.

I presume that the copyright should say 2020 only? It depends on the code that
ends up here. If you copy or move some code from some other file, in theory the
copyright date should follow.

Simon