From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 068CD38930E9 for ; Wed, 29 Apr 2020 21:09:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 068CD38930E9 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 504A6ABBD; Wed, 29 Apr 2020 21:09:06 +0000 (UTC) Subject: Re: [PATCH v2][PR gdb/17320] Fix array pretty formatter To: Hannes Domani , Gdb-patches References: <20200427125900.5587-1-ssbssa.ref@yahoo.de> <20200427125900.5587-1-ssbssa@yahoo.de> <86e4c9c8-77bc-00c0-526c-b2974e15d7b9@simark.ca> <509127707.4013029.1588157997483@mail.yahoo.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <96600c7d-fa3c-3b0e-f213-7809a92e1de4@suse.de> Date: Wed, 29 Apr 2020 23:09:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <509127707.4013029.1588157997483@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, BODY_8BITS, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 21:09:09 -0000 On 29-04-2020 12:59, Hannes Domani via Gdb-patches wrote: > Am Dienstag, 28. April 2020, 17:17:29 MESZ hat Simon Marchi Folgendes geschrieben: > >> On 2020-04-27 8:59 a.m., Hannes Domani via Gdb-patches wrote: >> >>> Currently, printing with array pretty formatting makes the output actually >>> less readable than without: >>> >>> (gdb) p -array on -- {{1,2,3},{4,5,6}} >>> $1 =  {    {1, >>>     2, >>>     3}, >>>       {4, >>>     5, >>>     6}} >>> (gdb) p -array on -array-indexes on -- {{1,2,3},{4,5,6}} >>> $2 =  {[0] =    {[0] = 1, >>>     [1] = 2, >>>     [2] = 3}, >>>   [1] =    {[0] = 4, >>>     [1] = 5, >>>     [2] = 6}} >>> >>> These changes now also put the first element and the array end bracket on a new >>> line, similar to the structure pretty formatter: >>> >>> (gdb) p -array on -- {{1,2,3},{4,5,6}} >>> $1 = { >>>   { >>>     1, >>>     2, >>>     3 >>>   }, >>>   { >>>     4, >>>     5, >>>     6 >>>   } >>> } >>> (gdb) p -array on -array-indexes on -- {{1,2,3},{4,5,6}} >>> $2 = { >>>   [0] = { >>>     [0] = 1, >>>     [1] = 2, >>>     [2] = 3 >>>   }, >>>   [1] = { >>>     [0] = 4, >>>     [1] = 5, >>>     [2] = 6 >> >>>   } >>> } >> >> Thanks for providing a test case, this is ok. > > Pushed, thanks. > Hi, this caused: ... Running /data/gdb_versions/devel/src/gdb/testsuite/gdb.python/py-format-string.exp ... FAIL: gdb.python/py-format-string.exp: format_string: lang_c: an_array with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_c: an_array_with_repetition with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print array on: an_array: no opts FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print array on: an_array: str FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print array on: an_array with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print array on: an_array_with_repetition: no opts FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print array on: an_array_with_repetition: str FAIL: gdb.python/py-format-string.exp: format_string: lang_c: set print array on: an_array_with_repetition with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_c: an_array with option array_indexes=True, pretty_arrays=True FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: an_array with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: an_array_with_repetition with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set print array on: an_array: no opts FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set print array on: an_array: str FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set print array on: an_array with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set print array on: an_array_with_repetition: no opts FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set print array on: an_array_with_repetition: str FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: set print array on: an_array_with_repetition with option pretty_arrays: pretty_arrays=true FAIL: gdb.python/py-format-string.exp: format_string: lang_cpp: an_array with option array_indexes=True, pretty_arrays=True === gdb Summary === # of expected passes 960 # of unexpected failures 18 ... Thanks, - Tom