From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-143889-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18383 invoked by alias); 29 Nov 2017 11:04:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 18364 invoked by uid 89); 29 Nov 2017 11:04:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 11:04:55 +0000
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 44295C052436;	Wed, 29 Nov 2017 11:04:54 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 9F633600D1;	Wed, 29 Nov 2017 11:04:53 +0000 (UTC)
Subject: Re: [PATCH, gdb/testsuite] Fix wrong return type in tests
To: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>, GDB Patches <gdb-patches@sourceware.org>
References: <e998867a-08b5-cbf2-004b-b9ce3d73c588@foss.arm.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <964a7f20-21f0-3e7f-a46a-6ef34cef046c@redhat.com>
Date: Wed, 29 Nov 2017 11:04:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <e998867a-08b5-cbf2-004b-b9ce3d73c588@foss.arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-11/txt/msg00761.txt.bz2

On 11/29/2017 10:48 AM, Thomas Preudhomme wrote:
> index 0990430c128413ecc21bcf65ebf58a1899f535fa..9f63fefcaeb800f7444fe74225514d3330036e5b 100644
> --- a/gdb/testsuite/gdb.cp/psymtab-parameter.cc
> +++ b/gdb/testsuite/gdb.cp/psymtab-parameter.cc
> @@ -16,7 +16,7 @@
>     along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
>  
>  template <typename T>
> -long
> +void
>  func ()
>  {
>  }
> diff --git a/gdb/testsuite/gdb.cp/psymtab-parameter.exp b/gdb/testsuite/gdb.cp/psymtab-parameter.exp
> index 3d78de91f4b3752d754bd776ae3532700a308a40..5c4b6ac71927fe9030bd9ce66111761425ab433b 100644
> --- a/gdb/testsuite/gdb.cp/psymtab-parameter.exp
> +++ b/gdb/testsuite/gdb.cp/psymtab-parameter.exp
> @@ -31,6 +31,6 @@ gdb_test_no_output "set language c++"
>  # XFAIL than FAIL here.  For example -readnow breaks it.
>  gdb_test_no_output "maintenance info symtabs"
>  
> -# GDB has shown only the `long func<short>()' ELF symbol before, not the DWARF
> +# GDB has shown only the `void func<short>()' ELF symbol before, not the DWARF
>  # symbol
>  gdb_test "complete p 'func<short>(" "p 'func<short>\\(\\)"

I think the return type may have been significant for this test.
See comments around DMGL_RET_DROP in commit 900e11f9ec1e.

Thanks,
Pedro Alves