From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125616 invoked by alias); 17 Sep 2018 10:58:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125602 invoked by uid 89); 17 Sep 2018 10:58:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 10:58:53 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CA3F1308FB8B; Mon, 17 Sep 2018 10:58:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2BCA07838E; Mon, 17 Sep 2018 10:58:51 +0000 (UTC) Subject: Re: [PATCH 1/2] Remove munmap_listp_free_cleanup To: Tom Tromey , gdb-patches@sourceware.org References: <20180915222411.24764-1-tom@tromey.com> <20180915222411.24764-2-tom@tromey.com> From: Pedro Alves Message-ID: <9642b747-7f95-fe5d-4cf3-b0d623ec40ae@redhat.com> Date: Mon, 17 Sep 2018 10:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180915222411.24764-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00564.txt.bz2 On 09/15/2018 11:24 PM, Tom Tromey wrote: > -static void > -munmap_listp_free_cleanup (void *headp_voidp) > +munmap_list::~munmap_list () > { > - struct munmap_list **headp = (struct munmap_list **) headp_voidp; > - > - munmap_list_free (*headp); > + for (auto &item : items) > + gdbarch_infcall_munmap (target_gdbarch (), item.addr, item.size); > } I think we should wrap that in try/catch, because an infcall can be aborted/throw, and we're in a destructor. Thanks, Pedro Alves