From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UB9EFd3S1GD3IQAAWB0awg (envelope-from ) for ; Thu, 24 Jun 2021 14:45:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 54E751F1F2; Thu, 24 Jun 2021 14:45:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E06051E939 for ; Thu, 24 Jun 2021 14:45:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4DA4F39B2420 for ; Thu, 24 Jun 2021 18:45:48 +0000 (GMT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id 03395385700A for ; Thu, 24 Jun 2021 18:45:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 03395385700A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id b3so7779694wrm.6 for ; Thu, 24 Jun 2021 11:45:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c/7SgxwvYuAynxabeNbepi3WUdwJ1G8j4CFmilp6W+c=; b=F1gWiX+29nd2FYxrC1STBF6Gt5RdqiwA7yGsU3+dk609yZKTv1dmyoV8lM2fDYnhYq AUSP/B755lZ2yDs+EeCfKMx0oyubI9k8XCC9l6BtVeNglQ+PHOwXa5etz7hnFNpEMAsV gPaXIc7VQ5ilwgYJqYB0GeKR1x9vOBonjNQM0o/FOLksLUZD89I5D3tfpW2GNTAV/u6x wovN7jlVPLe4Nrd1IXFW+Cfru/HFSNfWVVMIljZQ14QVW61yQehYcxN9WFanFyE4xzNw YmX0kU526g/3yhc4t4p1V9BAKVFBKYzZ1ovKUd4zedglHNgnyxHMZBXIdGyAYZLsfXKX kswA== X-Gm-Message-State: AOAM532y/7SVn1tFWqZvLWvPU1N2Ranqv9aMtWkjRL3VwHWI9ypCPS1X kD2mN0B65xPih/5qIT8LDI+NfW20RK1nyQ== X-Google-Smtp-Source: ABdhPJz1ptL+CgeKFxZT4tFJGJNOUB2GOSIcSLSjA0wFb3SIrvVUSZuq4Ho+/Kgyc6i1t+6RUFUwFg== X-Received: by 2002:adf:f587:: with SMTP id f7mr6327828wro.253.1624560334465; Thu, 24 Jun 2021 11:45:34 -0700 (PDT) Received: from ?IPv6:2001:8a0:f932:6a00:46bc:d03b:7b3a:2227? ([2001:8a0:f932:6a00:46bc:d03b:7b3a:2227]) by smtp.gmail.com with ESMTPSA id g10sm3679506wmh.33.2021.06.24.11.45.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 11:45:33 -0700 (PDT) Subject: Re: [PATCH] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS From: Pedro Alves To: Simon Marchi , gdb-patches@sourceware.org References: <20210615054416.1232-1-vapier@gentoo.org> <33565c24-0468-1ded-63db-d7ef402d5329@polymtl.ca> <5ece9821-45a3-14f6-33a1-3506b6efe72f@polymtl.ca> <4f273dab-3803-9143-7b16-4cb873834dd0@palves.net> Message-ID: <96320ece-2976-2b3e-405e-7b7d339ab8ed@palves.net> Date: Thu, 24 Jun 2021 19:45:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-23 11:26 p.m., Mike Frysinger wrote: > On 23 Jun 2021 10:38, Pedro Alves wrote: >> On 2021-06-18 5:38 a.m., Mike Frysinger via Gdb-patches wrote: >>> >>> how about at the top of acinclude.m4: >>> dnl NB: When possible, try to avoid explicit includes of ../config/ files. >>> dnl They're normally found by aclocal automatically and recorded in aclocal.m4. >>> dnl However, some are kept here explicitly to silence harmless warnings from >>> dnl aclocal when it finds AM_xxx macros via local search paths instead of >>> dnl system search paths. >>> -mike >> >> That seems good to me, but I think better would be to put all such include lines >> together and put the comment right on top of that section. Like: >> >> dnl NB: When possible, we try to avoid explicit includes of ../config/ files. >> dnl They're normally found by aclocal automatically and recorded in aclocal.m4. >> dnl However, the following are kept here explicitly to silence harmless warnings >> dnl from aclocal when it finds AM_xxx macros via local search paths instead of >> dnl system search paths. >> m4_include([../config/foo.m4]) >> m4_include([../config/bar.m4]) >> >> >> I've had my share of "comments at the top" that I've missed in the past... > > how about: > LGTM, thanks. I'd still suggest tweaking the comments to make it clearer that by "some are kept" we're talking about the ones right below the comment, like say, "these below are kept" instead or something like that. Pedro Alves