From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2KpeNy9nZ2UWlBIAWB0awg (envelope-from ) for ; Wed, 29 Nov 2023 11:30:39 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=miK/yYIO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DFB8B1E11B; Wed, 29 Nov 2023 11:30:39 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D0F191E091 for ; Wed, 29 Nov 2023 11:30:37 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 295B8383F5F6 for ; Wed, 29 Nov 2023 16:30:37 +0000 (GMT) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id E92DB385842B for ; Wed, 29 Nov 2023 16:30:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E92DB385842B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E92DB385842B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701275424; cv=none; b=l3XskEsTskFEl3hhqb0v6zWU46JXi7xjGYIC3+QEkDjN1JoHo8lloL3a/ywTMbHB3aWyAJ6cQgiU8cFaBGUGhMfGCV48qRinxEvqwyriM3m9l6T94JyrumuyVWtQZPY9cs9WMV4gbhKkPq0cFa0nOX9VyUJfd7koEatzulipen0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701275424; c=relaxed/simple; bh=g79WLhYxk9isFBY1Be7EdGZy1Ta8JLeN0h+H4wLR2RM=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:Mime-Version; b=p6544EMy9/m5L2vTPLVkxov3Ja8+KmDCCTwjnuw2u+hE4cEr15Z4P/+E8iFJBgT/AwE/942hAml+tbRz4Xj+Y6Mdf0d8N3WjFeuRx+YbJlUsq9kBwdAtdsjRvbL8yMmZGlVavpc6lsDwWf9kKpY+F/l+PYQn4Nnx76vLq4VGuN0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ATGN2VQ006564; Wed, 29 Nov 2023 16:30:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=oxMfV9hhaeIDygsYO2pPeX55f23o4uMHVix+X7ndP3U=; b=miK/yYIO2qDdplO+BI3iuieoed/hIxysKfryeH4D715yjUiTtF2XDvfbbzM2+LyCiLj+ yxFAs1RKxUqX4lPM/tKySSlAfvBs7Fji4RZb40xGiouyqGFnN4g6X+r2Ywfab9oC9liD xgMS0IB3SJBmpMyfIMezLYbuw1WoJhM3V69fnyWyzP/KFla5UKwUA6og68k2JHa8jt7b kixuGEv721pzL7SznDi2Q4mnhlrVI1v+YSH12LN6jqdV7AXu/30bAraUt/+yeQDS1tAt Tvf7yxnggEEjgTL9gpbPYI1vMA2TaFQ3synGaWUC1L8FUQemT8iGCwBiDx3M2MIZrttU 0w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3up8s8r98p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Nov 2023 16:30:16 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ATGNlwW011684; Wed, 29 Nov 2023 16:30:16 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3up8s8r96a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Nov 2023 16:30:16 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3ATEA5xZ022036; Wed, 29 Nov 2023 16:30:15 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([172.16.1.72]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3uku8t8ns3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 29 Nov 2023 16:30:15 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3ATGUDTA17236686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 29 Nov 2023 16:30:14 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C3E5958052; Wed, 29 Nov 2023 16:30:13 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A277D5805E; Wed, 29 Nov 2023 16:30:12 +0000 (GMT) Received: from wecm-9-67-78-200.wecm.ibm.com (unknown [9.67.78.200]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 29 Nov 2023 16:30:12 +0000 (GMT) Message-ID: <9623aa811826c6c20b17daf3ec548a7f7f0dbf99.camel@linux.ibm.com> Subject: Re: [ PATCH 1/3] Fix GDB reverse execution behavior From: Carl Love To: Luis Machado , blarsen@redhat.com, Ulrich Weigand , gdb-patches@sourceware.org Cc: Pedro Alves , Tom Tromey , Simon Marchi , cel@linux.ibm.com Date: Wed, 29 Nov 2023 08:30:11 -0800 In-Reply-To: <99a2fbb3-23b0-4b55-b177-bbeaa2c5334b@arm.com> References: <890101c23dd5fa60fcbf9d4b299cb2a533c260b7.camel@linux.ibm.com> <1e702d8f-e5b4-4719-b1e7-42210f350305@arm.com> <643afce1-ab9b-4e8b-bcbb-5738dc409a28@arm.com> <9e17008084c34f953f5318933436ec703250120a.camel@linux.ibm.com> <92a751d1-a4b9-4c21-821e-a1dc67207516@arm.com> <0743198c95396b679bd2215a6518d9e97ffa80f5.camel@linux.ibm.com> <99a2fbb3-23b0-4b55-b177-bbeaa2c5334b@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: KHo8zDphwd1w2kfc41PFVB7G4W8r1QVF X-Proofpoint-ORIG-GUID: 06H6BEL6IET1SlvMALRsbqWFFA_TX3rI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-29_14,2023-11-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=581 phishscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 adultscore=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311290125 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Luis: On Wed, 2023-11-29 at 11:44 +0000, Luis Machado wrote: > > + } else { > > + error "Option gcolumn-info option not supported by > > compiler." > > s/Option gcolumn-info option/Option gcolumn-info fixed > > > + } > > + > > + } elseif { $opt == "no-column-info" } { > > + if {[test_compiler_info {gcc-*}]} { > > + if {[test_compiler_info {gcc-[1-6]-*}]} { > > + # In this case, don't add the compile line option > > and > > + # the result will be the same as using no-column- > > info > > + # on a version that supports the option. > > + warning "gdb_compile option no-column-info not > > supported, ignoring." > > + } else { > > + lappend new_options "additional_flags=-gno- > > column-info" > > + } > > + > > + } elseif {[test_compiler_info {clang-*}]} { > > + lappend new_options "additional_flags=-gno-column- > > info" > > + > > + } else { > > + error "Option gno-column-info option not supported by > > compiler." > > s/Option gno-column-info option/Option gno-column-info fixed I made the fixes to the patches. The changes are fairly trivial so let s see if anyone else has any comments to add before sending out another version. Thanks for reviewing and testing. Carl