From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17204 invoked by alias); 24 Oct 2018 16:29:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16962 invoked by uid 89); 24 Oct 2018 16:29:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 Oct 2018 16:29:32 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A942030001DF; Wed, 24 Oct 2018 16:29:31 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CF83B65F48; Wed, 24 Oct 2018 16:29:30 +0000 (UTC) Subject: Re: [OB PATCH][gdb/testsuite] Handle removed valgrind option --db-attach To: Tom de Vries , gdb-patches@sourceware.org, Philippe Waroquiers References: <20181024111355.GA13788@delia> From: Pedro Alves Message-ID: <961cdab7-7882-6795-fac3-561db78d6593@redhat.com> Date: Wed, 24 Oct 2018 16:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181024111355.GA13788@delia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00550.txt.bz2 On 10/24/2018 12:13 PM, Tom de Vries wrote: > Hi, > > When running valgrind-db-attach.exp with valgrind version 3.13.0, we get: > ... > PASS: gdb.base/valgrind-db-attach.exp: spawn valgrind > valgrind: Unknown option: --db-attach=yes > valgrind: Use --help for more information or consult the user manual. > ERROR: Process no longer exists > UNRESOLVED: gdb.base/valgrind-db-attach.exp: valgrind started > ... > > The valgrind option --db-attach has been deprecated in version 3.10.0, and > removed in version 3.11.0. > But was it replaced with / renamed to something else equivalent, or the functionality completely eliminated? If the latter, I don't see much value in keeping the test case around going forward. Especially if we have no comment in the source indicating when it stopped being useful... It ends up just being dead weight and future gdb developers won't even realize. Thanks, Pedro Alves > Fix valgrind-db-attach.exp to replace the ERROR/UNRESOLVED with: > ... > UNSUPPORTED: gdb.base/valgrind-db-attach.exp: valgrind started > ... > > Tested on x86_64-linux. > > Committed as obvious. > > Thanks, > - Tom > > [gdb/testsuite] Handle removed valgrind option --db-attach > > 2018-10-24 Tom de Vries > > * gdb.base/valgrind-db-attach.exp: Handle removed support for > --db-attach in valgrind. > > --- > gdb/testsuite/gdb.base/valgrind-db-attach.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/gdb.base/valgrind-db-attach.exp b/gdb/testsuite/gdb.base/valgrind-db-attach.exp > index 3be6af5ca9..3e40283a95 100644 > --- a/gdb/testsuite/gdb.base/valgrind-db-attach.exp > +++ b/gdb/testsuite/gdb.base/valgrind-db-attach.exp > @@ -51,6 +51,10 @@ set use_gdb_stub 1 > set test "valgrind started" > # The trailing '.' differs for different memcheck versions. > gdb_test_multiple "" $test { > + -re "valgrind: Unknown option: --db-attach=yes" { > + unsupported $test > + return -1 > + } > -re "Memcheck, a memory error detector\\.?\r\n" { > pass $test > } >