From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KO0AK5J8lGQK+QoAWB0awg (envelope-from ) for ; Thu, 22 Jun 2023 12:53:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=vIxl5tZz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AD53E1E0BB; Thu, 22 Jun 2023 12:53:38 -0400 (EDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9DCBF1E0AC for ; Thu, 22 Jun 2023 12:53:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07AF93858D37 for ; Thu, 22 Jun 2023 16:53:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07AF93858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1687452816; bh=NjlQ0eD803q2mzYXQZOsq4truA1TB/CSv+/nM5ZXpkY=; h=Subject:To:Cc:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=vIxl5tZzi4LmJtAXP8c/8wEBCztErA3UbCuQfA6QHapmNx4FohFXsZHxo20IMGwxR MnXjPGWiL5igC13F5cN4GjQsfukWOaKMI9Q2YoVL3mKW33m4yZbrgzGnKHdkd1m9RS Kk7rqAWZuESOwPx9YAnQK56Dh2Q/vQ0LA8x/RYBs= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 3AE353858D35 for ; Thu, 22 Jun 2023 16:53:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3AE353858D35 Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35MGlYCL028269; Thu, 22 Jun 2023 16:53:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rct4r03en-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 16:53:00 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 35MGoAdw001996; Thu, 22 Jun 2023 16:53:00 GMT Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rct4r03ea-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 16:53:00 +0000 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35M7G0h5005581; Thu, 22 Jun 2023 16:52:59 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma03dal.us.ibm.com (PPS) with ESMTPS id 3r94f5gynf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Jun 2023 16:52:59 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35MGqvgn59900370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 22 Jun 2023 16:52:57 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8594A58056; Thu, 22 Jun 2023 16:52:57 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC22D58054; Thu, 22 Jun 2023 16:52:56 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.61.18.149]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 22 Jun 2023 16:52:56 +0000 (GMT) Message-ID: <95df539fed378baea3dd679bb10d33c57260f318.camel@us.ibm.com> Subject: Re: [PATCH 1/2] Fix reverse stepping multiple contiguous PC ranges over the line table. To: Simon Marchi , Bruno Larsen , gdb-patches@sourceware.org, UlrichWeigand , pedro@palves.net Cc: luis.machado@arm.com, cel@us.ibm.com Date: Thu, 22 Jun 2023 09:52:56 -0700 In-Reply-To: References: <74630f1ccb6e9258ae60682105ee5490726fb255.camel@us.ibm.com> <46d73c69-9168-44c6-b515-23dd893fc0eb@redhat.com> <86c65f2ad74caffc162f100e4e9c5be9062a7f59.camel@us.ibm.com> <0a2c4ebd-f01d-4b96-1b13-25d7276056a5@redhat.com> <956b8c3c9a7bdc3aa6f9a040619ec4778edc9c94.camel@us.ibm.com> <89b2fb027024f7e97de7196ee091a0ca11c0c2b3.camel@us.ibm.com> <0943e12c-049d-f8b0-c4c5-8816b1be1e45@simark.ca> <961a88a7-a820-fd32-c7ee-e707697e22a5@simark.ca> <60ba16fb9207f7e6313265aa0a118f65787b52f7.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: I0-yoDFs-zxFodvrQm2FNx8Y201XunZt X-Proofpoint-ORIG-GUID: VOKtGrO7RymvRW-dSc6GqKrEE_wTYqsM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-22_12,2023-06-22_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 bulkscore=0 mlxlogscore=999 spamscore=0 impostorscore=0 malwarescore=0 suspectscore=0 mlxscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306220140 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carl Love via Gdb-patches Reply-To: Carl Love Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Simon: On Mon, 2023-06-19 at 13:11 -0400, Simon Marchi wrote: > > --- a/gdb/testsuite/lib/gdb.exp > > +++ b/gdb/testsuite/lib/gdb.exp > > @@ -4794,6 +4794,8 @@ proc quote_for_host { args } { > > # debug information > > # - text_segment=addr: Tell the linker to place the text > > segment at ADDR. > > # - build-id: Ensure the final binary includes a build-id. > > +# - no-column-info: Disable generation of column table > > information. > > +# - column-info: Enable generation of column table information. > > # > > # And here are some of the not too obscure options understood by > > DejaGnu that > > # influence the compilation: > > @@ -5003,6 +5005,34 @@ proc gdb_compile {source dest type options} > > { > > } else { > > error "Don't know how to handle text_segment > > option." > > } > > + } elseif { $opt == "column-info" } { > > + if {[test_compiler_info {gcc-*}]} { > > + if {[test_compiler_info {gcc-[1-6]-*}]} { > > + error "gdb_compile option no-column-info not > > supported." > > I think this path should return the equivalent of "failed to > compile", > instead of throwing an error. Control will go back to the test, > which > will generally skip the portion of the test that requires that > binary. Not entirely sure how to accomplish what you are looking for. I change: error "gdb_compile option no-column-info not supported." to set result "option no-column-info not supported." clone_output "gdb compile failed, $result" return 1 When I force the if {[test_compiler_info...]} tp be true to test this, I get: get_compiler_info: gcc-12-2-1 gdb compile failed, option no-column-info not supported. UNTESTED: gdb.reverse/func-map-to-same-line.exp: with_column_info=yes: failed t\ o prepare testcase /home/carll/GDB/build-reverse-multiple- contiguous/gdb/testsuite/../../\ ../binutils-gdb-reverse-multiple- contiguous/gdb/testsuite/gdb.reverse/func-map-\ to-same-line.exp completed in 0 seconds === gdb Summary === # of untested testcases 1 The test case doesn't have any part of the test that doesn't require compiling so it is not clear if that would work with this fix. Anyway, wanted to run that by you to see if this is an appropriate fix? I am really not sure about it. Thanks. Carl