From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 929qMAGxLWUsry8AWB0awg (envelope-from ) for ; Mon, 16 Oct 2023 17:54:09 -0400 Received: by simark.ca (Postfix, from userid 112) id C108F1E0C1; Mon, 16 Oct 2023 17:54:09 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B55CF1E091 for ; Mon, 16 Oct 2023 17:54:07 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 74167385734B for ; Mon, 16 Oct 2023 21:54:07 +0000 (GMT) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id 85F07385840C for ; Mon, 16 Oct 2023 21:53:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85F07385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 85F07385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697493236; cv=none; b=uhSjr7ag1VDXPJS8jfZncnN1NPsDvtA0fTj6PPz2kb8rko2SIl5btvpCYDM7ZL251XIa4TXduXvilgYeOOMzNws2XDxjiJ4wHU/NSBdv11iL0dNNoPmupz0zxC1xZCHw+X3/ohl89FmOLYfqTYmy2tptGG7CJlGzWnuI/MVXaU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697493236; c=relaxed/simple; bh=4OnsnzMNmEve+51FC7I7MBKlAjoBATRTD6DSCq1n8jw=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=Jn8VRNDxHlMJD6QFWYPmB9149z0cR+g6q01pWsLw2HI42iU0FqzqT5VnX3yXRG1MxNYnu2hmV33pSRtu3ILffP9IV+YExk8zR7qZS4Lcxd1JTJbo5aKvQs6Z+IJGocx3StyXOA1/bKuB54btK5V15qxOBifZvYIjimowmAzeyFk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-406650da82bso46220925e9.3 for ; Mon, 16 Oct 2023 14:53:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697493234; x=1698098034; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uygThDIzngvjnZGAMARdx0o0Xiy8hDFrU0EWUl62pVI=; b=Ds1pjeO/vaMd7kUFJiQ3Am5x6BcBhU/HTBpgvZ2fGQDO5I1T2/gYTT+HsDZbCA6EGN f0KWQeg6eJ7d4TIBeVSE1jagh7MWv6Z0lcUcdLIlmAACh/zQlN2MYkegbea+3TDK9bMa Z2rEG4o/2uFnsLR7ZTBcfCyG0ZDcQm6ChWW73BXPNTHpgDBWV7d5FLmTVjS2c4J8r7Jt QQ36jiugXDGyHSMpFsJbiNEEXXGzPO0IA2YpOTrRxnhO3BZmpRmNXRyh7fk0o4KEYwwO akbwyQSX6+Gp9uyZESL7av7MA16wOz0oAWUG3Rg5kjd+XowdrxWx88rJwh1S0LXl88yB R/NA== X-Gm-Message-State: AOJu0YwqOd27dKYfXc6z1K53ASvLdciXb/F3/KJ1fHO0eFJqYMaKbHsR ndLZ19LvWmMMCxtpXypqZaw1kcEkhp6b5Q== X-Google-Smtp-Source: AGHT+IF/q/mi2O7dO7VlU6QFh3UYQb/5mmBdVb0RymKmigUQYYzzxkobe1lrtV9SlSGOl+HAB9Fofw== X-Received: by 2002:a05:600c:354c:b0:401:73b2:f039 with SMTP id i12-20020a05600c354c00b0040173b2f039mr307073wmq.7.1697493233992; Mon, 16 Oct 2023 14:53:53 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:120b:b0fa:905:a893? ([2001:8a0:f939:d200:120b:b0fa:905:a893]) by smtp.gmail.com with ESMTPSA id r20-20020a05600c35d400b0040596352951sm8232169wmq.5.2023.10.16.14.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 14:53:53 -0700 (PDT) Message-ID: <95cba198-ad2c-4959-8d46-ef87d1492b91@palves.net> Date: Mon, 16 Oct 2023 22:53:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/11] GDB: Require C++17 Content-Language: en-US To: Tom Tromey , Lancelot Six Cc: gdb-patches@sourceware.org References: <20231013144418.3180617-1-lancelot.six@amd.com> <87o7gyqros.fsf@tromey.com> From: Pedro Alves In-Reply-To: <87o7gyqros.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2023-10-16 20:43, Tom Tromey wrote: >>>>>> "Lancelot" == Lancelot Six writes: > > Lancelot> This series is a followup of the discussions from last Cauldron and Tom's > Lancelot> RFC patch[1] regarding requiring C++17 in GDB. It seems that the > Lancelot> overall sentiment is positive for such move, so here is a proper series. > > Hi. I've sent a few minor comments, but otherwise everything looks good > to me. > > Thank you for doing this. Ditto. > > Approved-By: Tom Tromey > > I'm giving my approval but this should probably wait a little for others > to comment as well. and ditto here too. You can add mine: Approved-By: Pedro Alves