From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88651 invoked by alias); 17 Jan 2017 17:04:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88632 invoked by uid 89); 17 Jan 2017 17:04:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Meaning, H*f:sk:b4c57b3, H*i:sk:b4c57b3, H*MI:sk:b4c57b3 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jan 2017 17:04:11 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 575A14E4CB; Tue, 17 Jan 2017 17:04:11 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0HH46Vt004351; Tue, 17 Jan 2017 12:04:06 -0500 Subject: Re: [RFA] candidates for ambiguous command in upper case To: Luis Machado , Jerome Guitton References: <1484058324-5368-1-git-send-email-guitton@adacore.com> <20170110150731.GH9518@E107787-LIN> <20170110151944.GD27546@adacore.com> <2c7e674b-e827-f433-cbaf-a3d1a20cba80@redhat.com> <20170111172550.GL9518@E107787-LIN> <20170112101854.GL27546@adacore.com> <85ecb095-a990-6f15-4fe9-5addffb3a5d0@redhat.com> <20170116163210.GG27546@adacore.com> <6872438c-e93a-77e8-79a3-c8e1f05aa283@codesourcery.com> Cc: Yao Qi , Simon Marchi , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <95bcfead-6b1a-305c-5064-0ffe961ca5f0@redhat.com> Date: Tue, 17 Jan 2017 17:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00331.txt.bz2 On 01/17/2017 04:51 PM, Luis Machado wrote: > On 01/17/2017 10:34 AM, Pedro Alves wrote: >> On 01/17/2017 04:29 PM, Luis Machado wrote: >>> >>> I don't see a problem with #1 as long as we keep it consistent >>> throughout from now on. >> >> Can you expand on exactly what you mean by the "as long" part? > Meaning that, if we go with #1, we should make sure we are not doing > case-insensitive comparisons in gdb unless it is clearly stated we > should do it (like handling of Windows paths i suppose). Would you say that we should stop completing "handle sig" to "handle SIG"? "handle" doesn't accept lowercase signal names, but it could be argued that the completer is helping the user here. Grepping for strncasecmp doesn't find all that many hits, and several are in symbol lookup or path handling stuff where they're probably rightly used. The ones in tracepoint.c do look like of the inconsistent-user-interface sort. I had never realized we accept $REG etc. in tracepoint actions. Thanks, Pedro Alves