From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27190 invoked by alias); 26 Sep 2019 17:48:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27181 invoked by uid 89); 26 Sep 2019 17:48:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 17:48:48 +0000 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B816BC08C33F for ; Thu, 26 Sep 2019 17:48:47 +0000 (UTC) Received: by mail-wm1-f71.google.com with SMTP id t185so1341929wmg.4 for ; Thu, 26 Sep 2019 10:48:47 -0700 (PDT) Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id q124sm5158565wma.5.2019.09.26.10.48.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2019 10:48:45 -0700 (PDT) Subject: Re: [PATCH v5] Improve ptrace-error detection on Linux targets To: Tom Tromey , Sergio Durigan Junior References: <20190819032918.3536-1-sergiodj@redhat.com> <20190926042155.31481-1-sergiodj@redhat.com> <87d0fngdyx.fsf@tromey.com> Cc: GDB Patches , Eli Zaretskii , Ruslan Kabatsayev From: Pedro Alves Message-ID: <95b321a8-4399-8bf0-1794-6089bc7aac3f@redhat.com> Date: Thu, 26 Sep 2019 17:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87d0fngdyx.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-09/txt/msg00535.txt.bz2 On 9/26/19 6:32 PM, Tom Tromey wrote: >>>>>> "Sergio" == Sergio Durigan Junior writes: > > Sergio> Changes from v4: > Sergio> - Don't add 'dont_throw' optional argument to gdb_dlopen; use > Sergio> conventional try..catch. > > Sergio> - Use snprintf when printing to 'own_buf' and make sure we don't > Sergio> overflow the buffer. > > Thank you for doing this. > I think this is ok, please check it in. Please give me a bit to review before merging. I think I spotted an issue, but I haven't had a chance to take a look at it since before Cauldron. Thanks, Pedro Alves