From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id olP1DmudsWBGaQAAWB0awg (envelope-from ) for ; Fri, 28 May 2021 21:48:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 2F5741F11C; Fri, 28 May 2021 21:48:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4CAFD1E813 for ; Fri, 28 May 2021 21:48:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98B193858039; Sat, 29 May 2021 01:48:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98B193858039 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1622252904; bh=OKQZLBZAhHSBFVyiHhcTFjnnK8nJ/KLVra8yIiBUUkE=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=K71tHoUs9Hy2c9t0qbbjyg8F73XCxjMVibeMgCAFKZdCcLAOEScL90hAOxedVfGMA jSvGhhs93PMquUm0QGP5+mdA3TQ+YULF9peAJbdWKzvcLu6oQVvQLL9uRIZf8tKE/s vcBopAEEC5/Lg3Y/yy3iPdEjA96evAFMG242ZPZU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7D568385800F for ; Sat, 29 May 2021 01:48:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7D568385800F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14T1mBcu018730 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 May 2021 21:48:17 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14T1mBcu018730 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 946F21E813; Fri, 28 May 2021 21:48:10 -0400 (EDT) Subject: Re: [PATCH] kill all threadapply processes at end of test To: Carl Love , Pedro Franco de Carvalho , gdb-patches@sourceware.org References: <87cztn7lk9.fsf@linux.ibm.com> <875yzflgzs.fsf@linux.ibm.com> <73bcfb777e72f549218cb431784e103b1831ea30.camel@us.ibm.com> Message-ID: <95a322dd-8059-8a48-acf5-07b965585995@polymtl.ca> Date: Fri, 28 May 2021 21:48:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 29 May 2021 01:48:11 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: ulrich.weigand@de.ibm.com, tom@tromey.com, rogealve@br.ibm.com Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-05-24 11:30 a.m., Carl Love wrote: > Simon, Tom, Pedro, GCC maintainers: > > I have implemented the test changes to use pthread barrier rather then > the spin loop. The changes only require changing the test with no > changes to the expect scripts. > > The threadsapply test runs fine with no errors and no processes running > after the test with just the changes to threadapply.c. This approach > seems to work well and would be better then the previous patches to > kill the processes in the expect script. > > The patch has been tested on Power. Please let me know if you have any > additional comments or concern. Thanks. > > Carl Love > ---------------------------------------------------------------------- > Change test to use barrier wait > > gdb/testsuite/ChangeLog: > > 2021-05-22 Carl Love > > * gdb.threads/threadapply.c: Add global mybarrier. > (main): Add pthread_barrier_init. > (thread_function): Replace while loop with myp increment and > pthread_barrier_wait. Hi, The code looks good to me, but please add a suitable commit message, it should contain a description and explanation of the observed problem and the chosen solution, such that somebody not familiar with the issue can understand the rationale of the patch. Simon