From: Pedro Alves <pedro@palves.net>
To: Reuben Thomas <rrt@sc3d.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/doc] Fix to manual for description of remote protocol
Date: Wed, 22 Jul 2020 16:17:14 +0100 [thread overview]
Message-ID: <9589a0b3-9f16-dc03-70cd-84cf1f059ad5@palves.net> (raw)
In-Reply-To: <CAOnWdogAqB_zsEAooPA2tReQaucVQCxQJ-zZ8tBR74p6wm4hFA@mail.gmail.com>
On 7/22/20 2:58 PM, Reuben Thomas wrote:
> On Wed, 22 Jul 2020 at 14:56, Pedro Alves <pedro@palves.net <mailto:pedro@palves.net>> wrote:
>
> Thanks very much for the review!
>
> Note this should go to the gdb/doc/ChangeLog file instead.
>
>
> Apologies, I didn't see that file existed.
>
> I see you're dropping the reference to the s (step) command.
> However, either "s" or "vCont;s" _are_ mandatory if the target supports
> hardware single-step. E.g. an x86 stub that doesn't implement
> s or vCont;s won't work.
>
>
> Thanks for the correction.
>
> The choice of whether to require s is a little more complicated
> than that, but I don't think we need to go into too much detail here.
>
> Do you think the version below is clear enough?
>
>
> That looks great to me.
Alright, I've merged it.
Thanks!
prev parent reply other threads:[~2020-07-22 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 19:14 Reuben Thomas
2020-07-22 13:56 ` Pedro Alves
2020-07-22 13:58 ` Reuben Thomas
2020-07-22 15:17 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9589a0b3-9f16-dc03-70cd-84cf1f059ad5@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox