From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56259 invoked by alias); 17 Jul 2018 15:27:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56236 invoked by uid 89); 17 Jul 2018 15:27:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jul 2018 15:27:35 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w6HFRTVl030801 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 17 Jul 2018 11:27:34 -0400 Received: by simark.ca (Postfix, from userid 112) id 65DDA1EF28; Tue, 17 Jul 2018 11:27:29 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 01F231E077; Tue, 17 Jul 2018 11:27:29 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 17 Jul 2018 15:27:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 02/15] Remove some unneeded psymtab initializations In-Reply-To: <20180510222357.27332-3-tom@tromey.com> References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-3-tom@tromey.com> Message-ID: <9582d8730cf1f62af176a5dea8e41e51@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00517.txt.bz2 Hi Tom, This LGTM, I just have one comment. I think it can be pushed on its own too. On 2018-05-10 18:23, Tom Tromey wrote: > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c > index 8960fdc38d..be477e3d30 100644 > --- a/gdb/dwarf2read.c > +++ b/gdb/dwarf2read.c > @@ -6517,13 +6517,7 @@ dwarf2_create_include_psymtab (const char > *name, struct partial_symtab *pst, > subpst->dependencies[0] = pst; > subpst->number_of_dependencies = 1; > > - subpst->globals_offset = 0; > - subpst->n_global_syms = 0; > - subpst->statics_offset = 0; > - subpst->n_static_syms = 0; > - subpst->compunit_symtab = NULL; > subpst->read_symtab = pst->read_symtab; > - subpst->readin = 0; Just above this, there is: subpst->textlow = 0; subpst->texthigh = 0; Can they be removed too? Same thing in xcoffread. Simon