From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-164132-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 53860 invoked by alias); 12 Feb 2020 03:33:40 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 53806 invoked by uid 89); 12 Feb 2020 03:33:39 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Feb 2020 03:33:38 +0000
Received: from [10.0.0.11] (unknown [192.222.164.54])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 469071ED42;	Tue, 11 Feb 2020 22:33:37 -0500 (EST)
Subject: Re: [PATCH 3/8] Change fde table to a vector
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20200208152758.29385-1-tom@tromey.com> <20200208152758.29385-4-tom@tromey.com> <a8628675-5902-8923-d9c8-e294c6a317c1@simark.ca>
Message-ID: <95631920-585c-cb6a-fc5c-9d583c7efd6b@simark.ca>
Date: Wed, 12 Feb 2020 03:33:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2
MIME-Version: 1.0
In-Reply-To: <a8628675-5902-8923-d9c8-e294c6a317c1@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2020-02/txt/msg00434.txt.bz2

>> @@ -2215,42 +2198,20 @@ dwarf2_build_frame_info (struct objfile *objfile)
>>  	  warning (_("skipping .debug_frame info of %s: %s"),
>>  		   objfile_name (objfile), e.what ());
>>  
>> -	  if (fde_table.num_entries != 0)
>> -	    {
>> -	      fde_table.num_entries = num_old_fde_entries;
>> -	      if (num_old_fde_entries == 0)
>> -		{
>> -		  xfree (fde_table.entries);
>> -		  fde_table.entries = NULL;
>> -		}
>> -	      else
>> -		{
>> -		  fde_table.entries
>> -		    = XRESIZEVEC (struct dwarf2_fde *, fde_table.entries,
>> -				  fde_table.num_entries);
>> -		}
>> -	    }
>> -	  fde_table.num_entries = num_old_fde_entries;
>> +	  fde_table.resize (num_old_fde_entries);
>>  	}
>>      }
>>  
>>    /* Copy fde_table to obstack: it is needed at runtime.  */
> 
> I think that comment is stale.

Sorry, I just noticed that Luis had already pointed this out.

Simon