From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65472 invoked by alias); 9 Aug 2019 14:17:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65406 invoked by uid 89); 9 Aug 2019 14:17:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:767, HContent-Transfer-Encoding:8bit X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Aug 2019 14:17:47 +0000 Received: by mail-wr1-f66.google.com with SMTP id r1so98365307wrl.7 for ; Fri, 09 Aug 2019 07:17:47 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r11sm149350613wre.14.2019.08.09.07.17.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2019 07:17:45 -0700 (PDT) Subject: Re: [PATCH V2] AArch64 pauth: Indicate unmasked addresses in backtrace To: Alan Hayward , Tom Tromey References: <20190730144123.11135-1-alan.hayward@arm.com> <728af5fa-8e3d-845c-d72f-60b1d2067643@redhat.com> <474e8e87-50d4-874f-787f-ef5f5fbb6cc3@redhat.com> Cc: "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: <955aee56-6b01-47f6-6870-8d561a2083fc@redhat.com> Date: Fri, 09 Aug 2019 14:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-08/txt/msg00224.txt.bz2 On 8/9/19 2:22 PM, Alan Hayward wrote: > It looks like fixing the space just requires an additional call to uiout->text (" “). > > > How about I create a new field addr_flags? It would be a generic field into which > targets can add whichever fields they want to. > > I then could add a call to a new function gdbarch_print_addr_flags() which prints the > PAC on AArch64 and nothing on all other targets? That sounds like two different things. You could have the gdbarch method without the uiout field. Not sure what the uiout field buys you. If CLI and MI are going to print the same way, then it doesn't appear useful over field_string. The gdbarch method sounds fine. Thanks, Pedro Alves