From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CFwZHH3+g2q7cC4AWB0awg (envelope-from ) for ; Tue, 18 Aug 2026 02:41:01 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=X1tX8OAY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5CC801E166; Tue, 18 Aug 2026 02:41:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABFC81E033 for ; Tue, 18 Aug 2026 02:41:00 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 416094BA23E7 for ; Tue, 18 Aug 2026 06:40:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 416094BA23E7 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=X1tX8OAY Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 2CCC54BA2E1C for ; Tue, 18 Aug 2026 06:40:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2CCC54BA2E1C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2CCC54BA2E1C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787035230; cv=none; b=IoxqWUzvEMLUkCCNlY35xz1vDm+q4kBKpZBpBCbcteT98uhGMHDNK7CjcYZPHc0MEjxGH21YVL9d2eogHhTOwU6aj9E4Foe5axb2Wqy9QLvDVSMvZGFtZP+LKZV+hN15cwNIPE8KdiMjLIex4fkL6eDtmcfmMH+gkkQ053/eT98= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787035230; c=relaxed/simple; bh=aqNFbR07tu9q3YPSug0JRPrT6dKYhKmIhi7fY4Ycr6U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aK5Q8tE1pVb+FEtb22UHPBJT6dKhiPdCQyhbGPsye0UO3PHK7Z02K3rTHEB00ZOZ9WrT9OB0ei7/GzlFALOA1snxWjxJRgmmjO5NgAKnxBp4KQi3cAeOthH7vZk7UnTUbv9E2CE3jlPcXAa7CV4oqJJBG19Zqs4/SN6R2NA7G3U= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=X1tX8OAY DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2CCC54BA2E1C Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-49954b88fffso47342045e9.0 for ; Mon, 17 Aug 2026 23:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787035229; x=1787640029; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :cc:content-language:references:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T9FYpuioXyq0lFNAA8EbJ3UVS+JJK0uZi/Uw4AfX6QM=; b=X1tX8OAYZOGuHQOjo5vl0MwZgg0qoSYSWCzcEZBAKFHBElmLDYWhyN/qHzJYsFh/0O U8rTB+CBbpQ9dziv3p3UmEg/OQQKIKbc3c/TA0sCHSR9IE9kOwOn8mKlBwyWU+ED3G7t 0cs/jVagQpq6BgyMTfD6SiDQZcM4u3IV7d+kBx3Q6EASNFAga48gP6mFaAo8Gw7i4EAl XJX53/FzRQhjtklmegFX9UEPHtw0e2J0Pt6JtnsB3Ds/h2Aa/CE1PteleigiYm920wdT mBA9zGzB9Sk/A+C40OcfU06OoymeeALGzOHwegpPzG9h49Qjy+D5Kl/TyDXHsY7gCYry c4PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787035229; x=1787640029; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :cc:content-language:references:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T9FYpuioXyq0lFNAA8EbJ3UVS+JJK0uZi/Uw4AfX6QM=; b=U1PkLDLaqht9O3Fp+At7Em6ngepxy+frXtKjAengwvUV8jtS6y0KFKUaj3arPNGlnx 9HWWQDFxyyiYmUVMsdnzxN/MBXOKAiJwqOYnJ3BJVm1TswrOiQoh2z1JOa0eU5MjqdRt b684HMRmpRh27TZJODptiEqGgEj+PFKCXH8O9e+5BhnPn+dppLlx/E27tlrzzpvxj5QG 6bBVjHfHx3zDiq4qGUEkD2Z55l0VdAhajADzklEspmFtjNkmDKn1OqApRUCwabJ3hs8x /a1uwAUcXA2xHikCsuZYueIAG1OtnsOP70+YLObJ23aB0UDKnMcP1FEBe3Cc7WbxOQO3 VnFQ== X-Gm-Message-State: AOJu0YxoWgBHRGqu8zdOsEzlGmlGkFLOf0xBjNpHMHST6qpY7gC0sN5H 8DbEnvdX69JsMnTIS86H/Z1rAPeMW1I70K6gfNk5cScNksRZZkqwAJazwj54itMbIA== X-Gm-Gg: AR+sD10yuevRxs4oDhw+4rnYtJPpsfwF3RvR1VdmMF5jQrs/s3Oo4f4fPA1Ei2Hg5Ov NkGbwARrO1FpXdW+ze3lf3r5eSYvZmo4WCncVJm9dgUSmZ+nDpVgCtDCXQDp3FCppS/7JgeIBQy 15+n1jxNMDoxikiHxYVbT49lMBvXFrJ+MbVfar/dlNHUgGPVGHzPamHflSl/Cbbul+JN8MnY4fd QY3shjexd1Mfp5JJZkOQwpgPBiaM66uZmiL+bzHvMqQMXQBDFmm9AcRBVhDFTPx3el8rhhVxHDA R84/3z9PGDHUZIdDSarZxdfB5x9vjB/c55YLiYT2W9itUA2B0ja2JOp80b5jNscJMiT+mDklqhf P+qMfs2ZEHqReMa9gC6GtqhjSIXjWRodLQfbluAWNhUs5c5VEeoN6E9XRX3NOHaMHjVCLNb0kYg j42x043Uc9/r68ynqBT8HQiwTKIisqGimpiPVeYBz4movzd8T3PDmfnuHDh3tUPFEO2CmKAGNUb fUoju0FTt4j/HNgbcUaKOcfNK7n2ywdCzmgL8Xa61zyhUFMCCQc X-Received: by 2002:a05:600c:820d:b0:499:7a36:88b with SMTP id 5b1f17b1804b1-4998794402emr538172575e9.5.1787035229098; Mon, 17 Aug 2026 23:40:29 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a6c449dbsm8767956f8f.8.2026.08.17.23.40.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Aug 2026 23:40:28 -0700 (PDT) Message-ID: <94f0421e-2159-4483-b536-2473fa65ef4d@suse.com> Date: Tue, 18 Aug 2026 08:40:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/13] opcodes/z80: remove use of sprintf To: Simon Marchi References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-4-simon.marchi@efficios.com> Content-Language: en-US Cc: gdb-patches@sourceware.org, binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20260817151646.152571-4-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 17.08.2026 17:16, Simon Marchi wrote: > --- a/opcodes/z80-dis.c > +++ b/opcodes/z80-dis.c > @@ -768,11 +768,55 @@ pref_ind (struct buffer *buf, disassemble_info *info, const char *txt) > static int > print_insn_z80_buf (struct buffer *buf, disassemble_info *info); > > +struct sized_buf > +{ > + char *buf; > + size_t size; > +}; > + > +/* An fprintf_ftype implementation writing to STREAM, which must point to a > + struct sized_buf. */ > + > +static int ATTRIBUTE_PRINTF_2 > +sized_buf_printf (void *stream, const char *format, ...) > +{ > + va_list ap; > + int ret; > + struct sized_buf *sbuf = (struct sized_buf *) stream; We're in the (slow going) process of removing such unnecessary casts, in the interest of getting the amount of casts down in general. Please drop this one as well as ... > + va_start (ap, format); > + ret = vsnprintf (sbuf->buf, sbuf->size, format, ap); > + va_end (ap); > + > + return ret; > +} > + > +/* Same as sized_buf_printf, but as an fprintf_styled_ftype implementation. > + The style is ignored for now. */ > + > +static int ATTRIBUTE_PRINTF_3 > +sized_buf_styled_printf (void *stream, > + enum disassembler_style style ATTRIBUTE_UNUSED, > + const char *format, ...) > +{ > + va_list ap; > + int ret; > + struct sized_buf *sbuf = (struct sized_buf *) stream; ... the one here. > + va_start (ap, format); > + ret = vsnprintf (sbuf->buf, sbuf->size, format, ap); > + va_end (ap); > + > + return ret; > +} > + > static int > suffix (struct buffer *buf, disassemble_info *info, const char *txt) > { > char mybuf[TXTSIZ*4]; > + struct sized_buf sbuf = { mybuf, sizeof (mybuf) }; Please use ARRAY_SIZE() here. sizeof() happens to be correct for char[], but wouldn't be correct for e.g. wchar_t[]. Okay with these adjustments. Jan