From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ePtiE8NJiWC7IwAAWB0awg (envelope-from ) for ; Wed, 28 Apr 2021 07:40:51 -0400 Received: by simark.ca (Postfix, from userid 112) id 47E531F11C; Wed, 28 Apr 2021 07:40:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 17F181E01F for ; Wed, 28 Apr 2021 07:40:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C3A683939C33; Wed, 28 Apr 2021 11:40:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3A683939C33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619610049; bh=Hr164+rNLyf9cO/TZEIwftLhlEMkA16QkySPlc4Dkr4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=YKx5cTqj/hIP+lXHJwR/7fdRnz5oWtA7xl1OAcenyTHPKOBBtu1G21d+SzYVNiHzK TW1Hwarytk4hS1ZEfxxXLq5NhbqjpW3hlx4rkmUZuarCnLldFxFsKOkyEHFsCdRPzd QjQ4qDEQkea8+kPIeG3CWDdmsi8T7NtA1Aded4iU= Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2071.outbound.protection.outlook.com [40.107.236.71]) by sourceware.org (Postfix) with ESMTPS id B9E873939C0D for ; Wed, 28 Apr 2021 11:40:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B9E873939C0D ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GzgYVP+kgGtrXfsDZ4a5x55oq5GRJQ8D2v/gKCeXIZ6EeAGN8xGLJe/Q96b0iyW+/C3WIj8YmqZju7w/SPJ0T6+gFy3dGo4gKKmnP3Fu1RaVc/tOY5LWjNmKHKwt5k4Jz7efqZZ7SimVFno4DTa+QsjzeabshZ2rPjVWckBDFF7jPFHV3e5v/exEpk/YpsiBrJmCDaFmHb+XBTl3SlmMk2pF9VBxsESUQis4frBKAZ4l3tNbLYjIlh8+DezKL6i/hPQ+WE+tliXAeUgAybQmy5zGkXdgrSIFS9+G5ce/PfENfAzITHd+t3SgxwKONMku3T5p2VWiff9jovBjsO41Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hr164+rNLyf9cO/TZEIwftLhlEMkA16QkySPlc4Dkr4=; b=FE3jZJOaB5g6xDc3dXWOegGJAEG8L3VvufYaEF9yPIoKAsSVI0poMkpw+0q14y+fPT00ixeoZ4R/v2HPTVYjEo899WbMcBmSxJeBvOpZMzWRtnF4Dw/iUT2RkL3Tbwy6IqUWhXmX/rBA7hPfZjHRPjsFvyirB3qrRINEGfLUtxJAn1N8sEZGxJtNL/3QN+wRvMPayfjgtPMXcsbDa97stkvv2eHpcIh2M24A8XuWjc6VSBa+8QumoHvrfGUOioMZqC7aQ8jV5El55wN7xJ3EobK6bh00QvwrB9qWPQheDNCHC05B3INdgHkmkb6ZqfHBs++fTsm54t/QPLJnM//Ong== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR1201MB0236.namprd12.prod.outlook.com (2603:10b6:4:57::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 28 Apr 2021 11:40:44 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5%7]) with mapi id 15.20.4065.023; Wed, 28 Apr 2021 11:40:44 +0000 Subject: Re: [PATCH 13/43] Move piece_closure and its support to expr.c To: Simon Marchi , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-14-Zoran.Zaric@amd.com> <4a7b94fb-0940-4640-db41-198303a4fc4d@polymtl.ca> Message-ID: <94e83d8c-a8a0-634d-ade6-0690cce125c2@amd.com> Date: Wed, 28 Apr 2021 12:40:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 In-Reply-To: <4a7b94fb-0940-4640-db41-198303a4fc4d@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] X-ClientProxiedBy: LO2P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::13) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] (2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1) by LO2P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25 via Frontend Transport; Wed, 28 Apr 2021 11:40:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2c2dde21-aa47-483d-7d8f-08d90a3a757d X-MS-TrafficTypeDiagnostic: DM5PR1201MB0236: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gdau+QGlmQ7EcdZvWVVB7HV4rCNvU3EDesOzWcVug/wV8zEUFGP9Q9Bz2ohLEeghcfm/d+fxhDvsxLRhqjOY82ORc3L1Mf35AbEiQgQ6q8szzKP7EMQZ5HxeLaRiDzEXQ4DBxvtiP3CyEO61P7Ki4I1n2PD2AX3f1AhE99/NTPxj4r+oxMpt1GhNLbw9yMu/j6lG54hQp3uTY+PgD6hvRyxOWbWIG2qCifrq+KvVaXmjbKlOC43fplkQWKWDWNgHcLrR4I/iYlQHE0prn4fmuVotZz9Wg+KToDq+vxXsWsoC1TKQ2U9QP7kOEeJBppSeZ2JzGoyJcfjzaOsd+7YMk55NQMLBvxWri6d036WBx3S/rmabNAjR3A4NfOUg8W+SKFaUqKKQPgHOIe0tWvbpTNVe9VScnswSIIW2HLUwaIEqw7g986Bks0l1e4TlkksTtNQc+CnIzpB350Fp4LN5F6Ohw2ErW1LVUjZ7xHlgcoiAzjVR1WGc4DI56V61+3n+u2rzL2z1BHuHbZQzylF1kQ/rEdAUCKTxIExRKaRMmDUSG2QhtkaNPa48jt9OLqjId/J8dh79I6zr166pCbSbBZpuKdlhQcD8YBjNDqcz0/wesK1ByCWycTa1UW3qlZHRr+Hyh3dTCKfrxNFW4nFqZkq5vdckvddWHX11s6jSVfwWGFkX2OMugpflhmvoyHNp X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(39860400002)(346002)(376002)(6666004)(66556008)(83380400001)(8676002)(316002)(31696002)(2616005)(16526019)(38100700002)(478600001)(66946007)(31686004)(8936002)(53546011)(5660300002)(6486002)(86362001)(52116002)(66476007)(36756003)(186003)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?R3R4Rm1LMDJRazVaZDVWNElwODUrb0pxK3dMKzRqaE1IcjVwZzlqZkYzMEFH?= =?utf-8?B?VUY1bm1QSkltMElVSDNaWmNld1JIUkVWUlNkNWY0a0lpUjlpbEowR2NCQ0gx?= =?utf-8?B?SFFOZEhKYSt0UmlWazZZYkc4clZLUktIbk5KcjBjd0lxTEh1M2ZXUXVzdXd2?= =?utf-8?B?d1UzMG5wQW9RNDR6LzV4RXQwcHg5eEl1SkJlM2JMNnhRaFFWamFoTG0vWEwr?= =?utf-8?B?c00vSnQ0akNtSEZyblRwREIwclI3K1JIUHZWM093S1V3TCtYSUo4QXlJMHlt?= =?utf-8?B?SmFxR2YrU2JLRXZadGNUSmRiZjFjVWlLQU1TYjJZd2F4VHR3QXNtN0V3ZmIx?= =?utf-8?B?UkZxZnhLVm5pMFM4a0YyM25HZ1RyMFQvaThQc3BqY3ZsVXVkOUJsR1E2Z2t3?= =?utf-8?B?aFRCMEhiZTJGQUJDOGMrMTVEeGRTQXU3OThhLy91aE9ldXNNQTBpZ2JueWtX?= =?utf-8?B?c1JsbHhHa3FnSVhEYUQ0Rnc3NlNoMVZwd0V4aVZkMkNKUjZQWFlWMjlhMU1U?= =?utf-8?B?Qi9DWnY4Ni84cllXZkVHOUo2N0p6dmswU0VSMTZoSUVoVFovSVdNcmhnZHFz?= =?utf-8?B?c1hyenhxL1FxMUxiVi9lMjJsN1NMQmpRY2phb0k1bk51YVZ0MGJ4OStGNWk1?= =?utf-8?B?aVBHb0Y1cWQvbnBjalh2cGVjZUphY1owRUhqYUEyRVFVYkd1aWJHV0lLZjc4?= =?utf-8?B?T1hUbHo1MFdUL3FORE5JSTNBK1o5UkVURDZSQ2tUN3lnNnlnTjcwWlFHRitE?= =?utf-8?B?ZzY1WnlDd1NxMi9UcDU5enBsSnJRYTlwNFhhanF4SU1PNmMwZmg3Q1JUdlJu?= =?utf-8?B?OTNVbjlrWHBNL05ZZXpKKzVaRUlhOEVhWXkrZDJsMDZ6WDBTMG1JK1lZUU1E?= =?utf-8?B?a004UVJMTFdna3Q0aUZDdVFTVWVHbHF4Y2NaTEJTazFrQkczN3pWcWlxNG0x?= =?utf-8?B?RWJmblRPcjVEQjc2b0crdGpYWHVpcmNDbDZ4SVRHRkJqMk1ZRUxzWmFGLzVt?= =?utf-8?B?czFaWXNlUEh5eHVHMVJPa1RlVmxPTzdrSlpkUXpvQ250TmtCbUk1eEFsYlJy?= =?utf-8?B?OVRhRFdEeVZtU3pXdFJGSVZ5WVRTRW5qM3RFVFFzTU5uQm5YQWRKZW1TYW9i?= =?utf-8?B?MGtCZEx2emJQRy9OM2tXUzNaY1dJVU9HZFdsYmVrRENQcHJIeW14Z21HVGdx?= =?utf-8?B?dUhWTHNrMHA0Mkxyajh6elJkdzFBNnRQeUhHTndESkpqUmo2aHZZOUZlS3Er?= =?utf-8?B?ZlZOb0JhNG9EQnJDbnpWWno0eUo1NmhMWmtLL3pjTy8weVBZS29Gd2lXcnR1?= =?utf-8?B?Vm9aanZqbExYVE9EaGFrRVFHSjVVazdsRWxpTE1rU2svL1BVT04yb2hvZEhp?= =?utf-8?B?WVhmMWc5TW5MdmdzNE1vREZBVHlLNGI1N2dRYnZIa0NSdkhRR1l4V1pGUTI3?= =?utf-8?B?L3kvUE15QnUvNXh1eG16eVNKYi84UEVSV0hQdXZ0UHhsK3ovdDhZYXlHZDA0?= =?utf-8?B?OVJiRHBOMno5R2pmMG9YUStIQUdJWWxMRkQ0aWs5endTcithZ2tGTTNRTEI4?= =?utf-8?B?a0hWT1VVSEZiU0ttL0tNU2I5MjdNeGx4cWY0K1pPU29NV1A0aUZwOU93eEVW?= =?utf-8?B?UzBiQm9QdkQ3dG5KOURaTTNNRHd1Qy81QmhnWlpraHB6REI1WDRtaWQ2T0ZV?= =?utf-8?B?Y05DOWl0RzVCaGNCek5LZDErTjdpVHFYQmx0QkxQR3l3V1BtOUVud3h3WmJM?= =?utf-8?B?R2hUQ0pGdTlEMzk0TDFyMllnTktnb2szNGd2Nmw0WGJkaURBZ2FUR20vdEN6?= =?utf-8?B?czNyNzQ0N1htaWN4UCtrZG9pbG1tdnc3b3k3ZzU3ZlA1UE9DM3Q0VFVwU1Nz?= =?utf-8?Q?41bN65pvyy35P?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c2dde21-aa47-483d-7d8f-08d90a3a757d X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2021 11:40:44.6004 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QAsDCvDLQObL1mjcT9e77ADSmMPlsoRGRG07NxYe155Dyc7FFJPAgeAebSnmc3VbZMzhz3yyANExjO/N33K1Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0236 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 4/28/21 2:56 AM, Simon Marchi wrote: > [CAUTION: External Email] > > On 2021-03-01 9:45 a.m., Zoran Zaric via Gdb-patches wrote: >> @@ -300,4 +301,15 @@ extern const gdb_byte *safe_read_sleb128 (const gdb_byte *buf, >> extern const gdb_byte *safe_skip_leb128 (const gdb_byte *buf, >> const gdb_byte *buf_end); >> >> +extern const struct lval_funcs pieced_value_funcs; >> + >> +/* Allocate a closure for a value formed from separately-described >> + PIECES. */ >> + >> +struct piece_closure *allocate_piece_closure >> + (dwarf2_per_cu_data *per_cu, >> + dwarf2_per_objfile *per_objfile, >> + std::vector &&pieces, >> + struct frame_info *frame); > > Indent with two columns: > > struct piece_closure *allocate_piece_closure > (dwarf2_per_cu_data *per_cu, > dwarf2_per_objfile *per_objfile, > std::vector &&pieces, > struct frame_info *frame); Thanks, I will fix it in the next iteration. > >> @@ -96,8 +89,7 @@ enum debug_loc_kind >> DEBUG_LOC_INVALID_ENTRY = -2 >> }; >> >> -/* Helper function which throws an error if a synthetic pointer is >> - invalid. */ >> +/* See loc.h. */ >> >> static void >> invalid_synthetic_pointer (void) > > I don't think you wanted to change this comment. > Thanks, I will fix it in the next iteration. >> @@ -286,4 +278,13 @@ extern int dwarf_reg_to_regnum (struct gdbarch *arch, int dwarf_reg); >> extern int dwarf_reg_to_regnum_or_error (struct gdbarch *arch, >> ULONGEST dwarf_reg); >> >> +/* Fetch the value pointed to by a synthetic pointer. */ >> + >> +extern struct value *indirect_synthetic_pointer >> + (sect_offset die, LONGEST byte_offset, >> + dwarf2_per_cu_data *per_cu, >> + dwarf2_per_objfile *per_objfile, >> + struct frame_info *frame, >> + struct type *type, bool resolve_abstract_p = false); > > This would typically have two columns of indent: > > extern struct value *indirect_synthetic_pointer > (sect_offset die, LONGEST byte_offset, > dwarf2_per_cu_data *per_cu, > dwarf2_per_objfile *per_objfile, > struct frame_info *frame, > struct type *type, bool resolve_abstract_p = false); > > Although I found one instance in this file of a declaration formatted > like you did, it can be confusing. > > Simon > Thanks, I will fix it in the next iteration. Zoran