From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 8B2953851C0B
 for <gdb-patches@sourceware.org>; Mon, 25 May 2020 19:10:56 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B2953851C0B
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 3D8A21E792;
 Mon, 25 May 2020 15:10:56 -0400 (EDT)
Subject: Re: [PATCH v2 15/42] Make queue_and_load_dwo_tu receive a dwarf2_cu
To: Tom Tromey <tom@tromey.com>,
 Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
References: <20200512210913.5593-1-simon.marchi@efficios.com>
 <20200512211141.6073-16-simon.marchi@efficios.com>
 <87r1vb1ywv.fsf@tromey.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <94d03e94-01dd-8cc2-bc13-db4394f6e5b2@simark.ca>
Date: Mon, 25 May 2020 15:10:56 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <87r1vb1ywv.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 25 May 2020 19:10:57 -0000

On 2020-05-22 4:45 p.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> I kept this as a separate patch, because since there's no strong typing
> Simon> here, it's easy to miss something.
> 
> Good idea.
> 
> This is another area where (1) a variant of the GCC hash table would be
> nice, and (2) where I wish at least the libiberty hash table had
> external iteration.  (For (2), I know some code in GCC used to do this,
> but that always seemed like a bit of an abstraction violation to me.)
> 
> Tom
> 

Agreed :).

Simon