From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8eDSKYYUwGnoXjQAWB0awg (envelope-from ) for ; Sun, 22 Mar 2026 12:10:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CGjQJDfT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3Bm9r3sX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CGjQJDfT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3Bm9r3sX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A7D941E08C; Sun, 22 Mar 2026 12:10:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1C3281E08C for ; Sun, 22 Mar 2026 12:10:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id CEF4D4BB3B92 for ; Sun, 22 Mar 2026 16:10:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CEF4D4BB3B92 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CGjQJDfT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3Bm9r3sX; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CGjQJDfT; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3Bm9r3sX Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 5905D4BAD169 for ; Sun, 22 Mar 2026 16:10:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5905D4BAD169 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5905D4BAD169 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774195816; cv=none; b=vQZ81w7KV5kdwvXU9xoPP46xC0DTR9YzcBMZAm9McBN8B3cgsyP3G/BWJ/0S2HZhul7rDF36C17peE1zg0BfR1Xiuzgb7oKITjJP3OxEOWDGR828h5YjAkbHCmB+5OwVguyOwcgu6X9j64Rto8JI5Idq0VeZipNjbos/KvLhu0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774195816; c=relaxed/simple; bh=47nSpaRzRJweQR09BBbG6CMWz7VAnn4A6nzMdHeP2FA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=fkPpIqjgD30rHnFQaXHIMYUiwQH1jCMclpzpHnAfrLeiRsB+byj5zebl2kr98eUjjwYRvWSmu2QVxtM75pAxorROnvroZqjAxO2yvs6k6eJZ2OB+Jd2RgQYcDWE92/Ptr4psk5tEqgUWlNr96c+AOgC+8S3h0+6Ud7uuhgnIquE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5905D4BAD169 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A6E25BD04; Sun, 22 Mar 2026 16:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774195815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDYATAj4AVwEa02L5FZgr8AubE5mky35PwUON0TXy3E=; b=CGjQJDfTTW660gGa5XA7DjzfLK3CQwLYn67nvJq5PJxJpBREwnI52lCTSzovRZYt32q46e 84OE2XUQ7sO8prGbXQwKLk6barBAYg8kXNQKGA7qIJQ4TosN0z0AGz4DnQCsJhvvgg5Z9x UGZ4nz2kCRtBjaLRZ7ke3kf5gIS+6iA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774195815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDYATAj4AVwEa02L5FZgr8AubE5mky35PwUON0TXy3E=; b=3Bm9r3sXTqF8/q5zYTNDxIoAbRzUH/c2m67KyGb/hkbRJGAHegkcEsRiRCN9JjEIYl0u6Q QcXcibR1p9xfD5Bg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CGjQJDfT; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3Bm9r3sX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774195815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDYATAj4AVwEa02L5FZgr8AubE5mky35PwUON0TXy3E=; b=CGjQJDfTTW660gGa5XA7DjzfLK3CQwLYn67nvJq5PJxJpBREwnI52lCTSzovRZYt32q46e 84OE2XUQ7sO8prGbXQwKLk6barBAYg8kXNQKGA7qIJQ4TosN0z0AGz4DnQCsJhvvgg5Z9x UGZ4nz2kCRtBjaLRZ7ke3kf5gIS+6iA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774195815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDYATAj4AVwEa02L5FZgr8AubE5mky35PwUON0TXy3E=; b=3Bm9r3sXTqF8/q5zYTNDxIoAbRzUH/c2m67KyGb/hkbRJGAHegkcEsRiRCN9JjEIYl0u6Q QcXcibR1p9xfD5Bg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6E649433CF; Sun, 22 Mar 2026 16:10:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uPk/OWUUwGluVwAAD6G6ig (envelope-from ); Sun, 22 Mar 2026 16:10:13 +0000 Message-ID: <94cc49b3-0a14-4334-a348-f525a3d96cd0@suse.de> Date: Sun, 22 Mar 2026 17:10:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tdep] Eliminate ostringstream use from arc_check_tdesc_feature To: Simon Marchi , gdb-patches@sourceware.org References: <20260322065808.1127765-1-tdevries@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,sourceware.org:url,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,efficios.com:email]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 1A6E25BD04 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/22/26 3:41 PM, Simon Marchi wrote: > On 3/22/26 2:58 AM, Tom de Vries wrote: >> We generally avoid C++ streams in GDB sources [1]. >> >> Remove an instance of std::ostringstream in arc_check_tdesc_feature. >> >> While we're at it, fix an array index bug: >> ... >> - reg_names << " or '" << reg.names[0] << "'"; >> + string_appendf (reg_names, " or '%s'", reg.names[i]); >> ... >> >> Tested on x86_64-linux, using a trigger patch: >> ... >> - if (!found && reg.required_p) >> + if (true || (!found && reg.required_p)) >> ... >> and doing "maint selftest" and observing the output: >> ... >> Running selftest unpack_field_as_long::ARC600. >> Error: Cannot find required register(s) 'r0' in feature 'org.gnu.gdb.arc.core'. >> Error: Cannot find required register(s) 'pc' in feature 'org.gnu.gdb.arc.aux'. >> ... >> >> [1] https://sourceware.org/pipermail/gdb-patches/2026-March/226117.html >> --- >> gdb/arc-tdep.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> diff --git a/gdb/arc-tdep.c b/gdb/arc-tdep.c >> index ff283014e52..4936a5c8fbb 100644 >> --- a/gdb/arc-tdep.c >> +++ b/gdb/arc-tdep.c >> @@ -44,7 +44,6 @@ >> >> /* Standard headers. */ >> #include >> -#include >> >> /* The frame unwind cache for ARC. */ >> >> @@ -2100,16 +2099,16 @@ arc_check_tdesc_feature (struct tdesc_arch_data *tdesc_data, >> >> if (!found && reg.required_p) >> { >> - std::ostringstream reg_names; >> + std::string reg_names; >> for (std::size_t i = 0; i < reg.names.size(); ++i) >> { >> if (i == 0) >> - reg_names << "'" << reg.names[0] << "'"; >> + string_appendf (reg_names, "'%s'", reg.names[0]); >> else >> - reg_names << " or '" << reg.names[0] << "'"; >> + string_appendf (reg_names, " or '%s'", reg.names[i]); > Hi Simon, thanks for the review. > Looks like you fixed a bug here (0 -> i). Yes, that's what I meant by "fix an array index bug". Thanks, - Tom > Approved-By: Simon Marchi > > Simon