From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7oduCMzO0GAgQgAAWB0awg (envelope-from ) for ; Mon, 21 Jun 2021 13:39:24 -0400 Received: by simark.ca (Postfix, from userid 112) id 1576E1F1F2; Mon, 21 Jun 2021 13:39:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F07AE1E939 for ; Mon, 21 Jun 2021 13:39:22 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4EA483839828 for ; Mon, 21 Jun 2021 17:39:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4EA483839828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624297162; bh=5KJ+vr854yINXhWFuQN0n+G2IwWh/5ISYt+VmN2jerA=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=W2tK6MgkiAukXkaapRf2PtwyODCMWb3XimjdggybexsKCW4pn8Yn4wo7p9tDKemjV G3p0F69QahkajlFcCv/byA+Ngo41xf1WdHbz6xESK8H+nzmfJMVxYWdz26WenHiI04 JY0uDgqVq1WXG+Lyk18cGLl7sxyYtb2iiNPZ2RDk= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 784EA386FC1A for ; Mon, 21 Jun 2021 17:39:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 784EA386FC1A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15LHcv0N015755 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 21 Jun 2021 13:39:01 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15LHcv0N015755 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id ED2B71E939 for ; Mon, 21 Jun 2021 13:38:56 -0400 (EDT) Subject: Re: [PATCH 1/3] sim: split sim/callback.h include out To: gdb-patches@sourceware.org References: <20210616063302.20722-1-vapier@gentoo.org> Message-ID: <94ba52be-2bf0-b4ce-4572-57da5a45e701@polymtl.ca> Date: Mon, 21 Jun 2021 13:38:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 21 Jun 2021 17:38:57 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-20 4:56 p.m., Mike Frysinger wrote: > On 20 Jun 2021 11:11, Simon Marchi wrote: >> On 2021-06-16 2:33 a.m., Mike Frysinger via Gdb-patches wrote: >>> The sim-basics.h is too big and includes too many things. This leads >>> to some arch's sim-main.h having circular loop issues with defs, and >>> makes it hard to separate out common objects from arch-specific defs. >>> By splitting up sim-basics.h and killing off sim-main.h, it'll make >>> it easier to separate out the two. >>> >>> Start with splitting out sim/callback.h. >> >> Starting with this patch (according to bisect), I get this link error: > > bisecting is why i've been doing small/medium patches and not giant dumps :). > >> make[3]: Entering directory '/home/simark/build/binutils-gdb/sim/erc32' >> ccache gcc -DHAVE_CONFIG_H -DWITH_HW=1 -DHAVE_DV_SOCKSER -DDEFAULT_INLINE=0 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -I. -I/home/simark/src/binutils-gdb/sim/erc32 -I../common -I/home/simark/src/binutils-gdb/sim/erc32/../common -I../../include -I/home/simark/src/binutils-gdb/sim/erc32/../../include -I../../bfd -I/home/simark/src/binutils-gdb/sim/erc32/../../bfd -I../../opcodes -I/home/simark/src/binutils-gdb/sim/erc32/../../opcodes -I../.. -I/home/simark/src/binutils-gdb/sim/erc32/../../gnulib/import -I../../gnulib/import -DFAST_UART -I/home/simark/src/binutils-gdb/sim/erc32/../.. -g3 -O0 -fsanitize=address -fmax-errors=1 -fdiagnostics-color=always -o sis \ >> sis.o exec.o erc32.o func.o help.o float.o ../common/common_libcommon_a-portability.o ../common/common_libcommon_a-sim-load.o ../common/common_libcommon_a-version.o ../../bfd/libbfd.a ../../opcodes/libopcodes.a ../../libiberty/libiberty.a -lm -ltinfo -ldl -lnsl -lz -lreadline -ltinfo -lm ../../gnulib/import/libgnu.a >> /usr/bin/ld: ../common/common_libcommon_a-sim-load.o: warning: relocation against `current_target_byte_order' in read-only section `.text' >> /usr/bin/ld: ../common/common_libcommon_a-sim-load.o: in function `LSEXTRACTED': >> /home/simark/src/binutils-gdb/sim/common/sim-bits.c:64: undefined reference to `sim_io_error' > > this is weird. it builds fine for me with -O0. i just tried with sanitizers > enabled too and still passes. all with gcc-11.1. > > but let's focus on the error. > > LSEXTRACTED doesn't call sim_io_error. it does call the ASSERT macro which > might expand to calling sim_io_error, but that includes sim-io.h before using > the func. so that part looks ok. > > sim_io_error is defined in sim-io.o. but erc32 doesn't link that in. but it > also doesn't use it in general ... > > why does your sim-load have references to LSEXTRACTED et al in the first place ? > sim-load doesn't use any of those APIs. i guess this gets back to your system > not handling static/inline the way others are for some reason ? > > $ readelf -sW common/common_libcommon_a-sim-load.o | grep sim > 1: 0000000000000000 0 FILE LOCAL DEFAULT ABS sim-load.c > 17: 0000000000000127 990 FUNC GLOBAL DEFAULT 1 sim_load_file > -mike > Well, it builds fine now, I probably was just in a bad state. Sorry for the noise. Simon