From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23672 invoked by alias); 15 Jan 2019 14:14:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23642 invoked by uid 89); 15 Jan 2019 14:14:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:ba2125e, Hx-languages-length:833, H*f:sk:ba2125e, HContent-Transfer-Encoding:8bit X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Jan 2019 14:14:24 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x0FEEHo2017119 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Jan 2019 09:14:22 -0500 Received: by simark.ca (Postfix, from userid 112) id BACB01E7BB; Tue, 15 Jan 2019 09:14:17 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CB2821E077; Tue, 15 Jan 2019 09:14:16 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 15 Jan 2019 14:14:00 -0000 From: Simon Marchi To: Nick Clifton Cc: =?UTF-8?Q?=D0=9F=D0=B0=D0=B2=D0=B5=D0=BB_=D0=9A=D1=80=D1=8E=D0=BA?= =?UTF-8?Q?=D0=BE=D0=B2?= , gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] Include to dis-asm.h to get strchr declaration In-Reply-To: References: <1da4814ae31a668a24b80e162f5941a3@polymtl.ca> Message-ID: <9494a3a3f1a68aeeadf94fb70632e143@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00346.txt.bz2 On 2019-01-15 09:01, Nick Clifton wrote: > Hi Simon, > >>> Include to dis-asm.h to get strchr declaration > >>>  #include >>> +#include >>>  #include "bfd.h" > >> I took the liberty of pushing this patch which touches code in >> include/, since it seemed obvious enough to me. > > Do we need to worry about systems that have rather than > ? > > There are various places in the binutils sources (eg binutils/sysdep.h) > which > check for configure macros for these headers, which makes me wonder... From what I understand, these systems (BSDs, mostly) have strings.h in addition to string.h, where strings.h provide additional, non-standard functions. But strchr would still be found in string.h. Simon