From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107029 invoked by alias); 10 Jul 2018 04:25:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106852 invoked by uid 89); 10 Jul 2018 04:24:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 04:24:48 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 53C581E08D; Tue, 10 Jul 2018 00:24:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531196667; bh=DUn8zXB6rvMXwvyv5kB356ltChxSV+BDX+Ozm/oH1zs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=xFNeYPWCKaZgeYOFGrqeeqGVbtUjWWSLtw+5MO2gGzy4fZGTadIz06rL3CIpX0YUi Bfei60UAzqt8SkSYaEp8ywyQa+luA10jywLH1EzdnidcmRR2R4CTRXU91ZKuUGBIGA +IzVMoty73/cLZE6hL13y8xn1jd4Z3mBH1BADW+c= Subject: Re: [RFA 39/42] Parameterize cp_scan_for_anonymous_namespaces To: Tom Tromey , Keith Seitz Cc: gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-40-tom@tromey.com> <87058601-85e2-c7ec-7720-cac150f41a04@redhat.com> <87sh4t4r68.fsf@tromey.com> From: Simon Marchi Message-ID: <945ae674-4acf-28b9-0fba-d355d3ca74b6@simark.ca> Date: Tue, 10 Jul 2018 04:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87sh4t4r68.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00257.txt.bz2 On 2018-07-08 12:40 PM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> On 05/22/2018 09:58 PM, Tom Tromey wrote: >>> diff --git a/gdb/buildsym.c b/gdb/buildsym.c >>> index 3e3170f0ee..d9a0e02653 100644 >>> --- a/gdb/buildsym.c >>> +++ b/gdb/buildsym.c >>> @@ -1634,3 +1634,10 @@ record_line (struct subfile *subfile, int line, CORE_ADDR pc) >>> gdb_assert (buildsym_compunit != nullptr); > buildsym_compunit-> record_line (subfile, line, pc); >>> } >>> + >>> +struct buildsym_compunit * >>> +get_buildsym_compunit () >>> +{ >>> + gdb_assert (buildsym_compunit != nullptr); >>> + return buildsym_compunit; >>> +} > > Keith> Missing "See legacy-buildsym.h" comment. > > Thanks, I made this change. > > Tom > LGTM with this. Simon